Skip to content

chore(Log): remove unused getEntries method #53682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

Summary

This method hasn't been used since ~#2214. All this functionality was moved to the LogReader app. It was de facto deprecated nearly 10 years ago. There are zero references to it across all of GitHub. Technically a public API, but...

TODO

Checklist

Hasn't been used for many years (since #2214). All this functionality was moved to the LogReader app.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 32 milestone Jun 25, 2025
@joshtrichards joshtrichards requested a review from a team as a code owner June 25, 2025 14:21
@joshtrichards joshtrichards requested review from yemkareems and come-nc and removed request for a team June 25, 2025 14:21
@joshtrichards joshtrichards added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: logging feature: settings labels Jun 25, 2025
Signed-off-by: Josh <josh.t.richards@gmail.com>
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jun 25, 2025
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should go through deprecation procedure, even if unused.
It’s not broken or causing any trouble, so there’s no hurry in removing it I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: logging feature: settings pending documentation This pull request needs an associated documentation update ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants