Skip to content

feat(lexicon): moving out from unstable #53975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

feat(lexicon): moving out from unstable #53975

merged 5 commits into from
Jul 25, 2025

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 16, 2025 •
edited
Loading

  • moving UserConfig+Lexicon out of unstable into public:

NCU\Config\Lexicon\ConfigLexiconEntry; => OCP\Config\Lexicon\Entry
NCU\Config\Lexicon\ConfigLexiconStrictness => OCP\Config\Lexicon\Strictness
NCU\Config\Lexicon\IConfigLexicon =>OCP\Config\Lexicon\ILexicon
NCU\Config\ValueType => OCP\Config\ValueType
NCU\Config\Exceptions\IncorrectTypeException => OCP\Config\Exceptions\IncorrectTypeException
NCU\Config\Exceptions\IncorrectTypeException => OCP\Config\Exceptions\TypeConflictException
NCU\Config\Exceptions\IncorrectTypeException => OCP\Config\Exceptions\UnknownKeyException
NCU\Config\IUserConfig => OCP\Config\IUserConfig
NCU\Config\ValueType => OCP\Config\ValueType

@ArtificialOwl ArtificialOwl force-pushed the feat/lexicon/moving-out-from-unstable branch 6 times, most recently from 1d56728 to 07bc326 Compare July 17, 2025 19:52
@ArtificialOwl ArtificialOwl marked this pull request as ready for review July 18, 2025 19:46
@ArtificialOwl ArtificialOwl requested a review from a team as a code owner July 18, 2025 19:46
@ArtificialOwl ArtificialOwl requested review from Altahrim, artonge and come-nc and removed request for a team July 18, 2025 19:46
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Jul 18, 2025
@ArtificialOwl ArtificialOwl added this to the Nextcloud 32 milestone Jul 18, 2025
nfebe
nfebe approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nickvergessen
nickvergessen reviewed Jul 21, 2025
View reviewed changes
@ArtificialOwl ArtificialOwl force-pushed the feat/lexicon/moving-out-from-unstable branch from 9d53dcb to b0b7252 Compare July 22, 2025 10:45
@ArtificialOwl ArtificialOwl mentioned this pull request Jul 23, 2025
Merged
susnux
susnux reviewed Jul 24, 2025
View reviewed changes
susnux
susnux reviewed Jul 24, 2025
View reviewed changes
susnux
susnux reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New code probably needs the attributes setup for interfaces

@ArtificialOwl ArtificialOwl force-pushed the feat/lexicon/moving-out-from-unstable branch from c61a4d9 to 49ca420 Compare July 24, 2025 14:13
@ArtificialOwl
feat(lexicon): moving out from unstable
33bff30 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
feat(lexicon): marking unstable as @deprecated
4cd5183 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
feat(lexicon): marking unstable as @deprecated
a0c9fed 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
fix(lexicon): missing doc
f359904 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
feat(preset): split education based on size
011500f 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the feat/lexicon/moving-out-from-unstable branch from 49ca420 to 011500f Compare July 24, 2025 17:00
@ArtificialOwl ArtificialOwl merged commit de46e39 into master Jul 25, 2025
242 of 254 checks passed
@ArtificialOwl ArtificialOwl deleted the feat/lexicon/moving-out-from-unstable branch July 25, 2025 01:02
@nickvergessen nickvergessen mentioned this pull request Jul 25, 2025
Merged
4 tasks
@nfebe nfebe mentioned this pull request Jul 29, 2025
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jospoortvliet jospoortvliet jospoortvliet left review comments

@susnux susnux susnux approved these changes

@nfebe nfebe nfebe approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
5 participants
@ArtificialOwl @nickvergessen @jospoortvliet @susnux @nfebe