Basic endpoint implementation #255
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not called webhook because of potential confusion between this and the channel webhooks. This is for anything that receives HTTP requests originating from Discord's servers. My structure for this is going to be to - Create a adapter per web-framework that sets up a app and HTTP paths, and passes the processed data from the request to the main class - A main class, unsure of a name that takes the data from the adapters and dispatches it and does logic stuff. Unsure of how the different features like interactions and oauth are going to fit into this as there is quite a lot of features to cram into one class, however I don't know any better way to structure it.
The fastapi adapter is broken, please look at the aiohttp adapter of how I want things structured.
This also waits for error handlers. Conflicts with #253 is to be expected, sorry!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not called webhook because of potential confusion between this and the channel webhooks.
This is for anything that receives HTTP requests originating from Discord's servers.
My structure for this is going to be to
Unsure of how the different features like interactions and oauth are going to fit into this as there is quite a lot of features to cram into one class, however I don't know any better way to structure it.
TODO: