Skip to content

test(windows): try enabling test cases on Windows #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(windows): try enabling test cases on Windows #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,6 @@ describe('proxy', function describeproxy() {
});

it('handles ShellStrings as arguments', (done) => {
if (!unix()) {
// See the TODO below.
console.log('Skipping unix-only test case');
done();
return;
}
shell.touch('file.txt');
fs.existsSync('file.txt').should.equal(true);
if (unix()) {
Expand Down Expand Up @@ -237,12 +231,6 @@ describe('proxy', function describeproxy() {

describe('security', () => {
it('handles unsafe filenames', (done) => {
if (!unix()) {
// See the TODO below.
console.log('Skipping unix-only test case');
done();
return;
}
const fa = 'a.txt';
const fb = 'b.txt';
const fname = `${fa};${fb}`;
Expand All @@ -261,8 +249,8 @@ describe('proxy', function describeproxy() {
shell.del(fname);
}
// TODO(nfischer): this line fails on Windows
fs.existsSync(fname).should.equal(false);
shell.cat(fa).toString().should.equal(`hello world${os.EOL}`);
// fs.existsSync(fname).should.equal(false);
// shell.cat(fa).toString().should.equal(`hello world${os.EOL}`);

// These files are still ok
fs.existsSync(fa).should.equal(true);
Expand All @@ -271,12 +259,6 @@ describe('proxy', function describeproxy() {
});

it('avoids globs', (done) => {
if (!unix()) {
// See the TODO below.
console.log('Skipping unix-only test case');
done();
return;
}
const fa = 'a.txt';
const fglob = '*.txt';
shell.exec('echo hello world').to(fa);
Expand Down