Skip to content

Fix agent version reporting #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

Fix agent version reporting #1184

merged 4 commits into from
Jul 29, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 24, 2025

Proposed changes

Change Version to be Set instead of SetDefault, if agent was upgraded with settings in the dynamic config the version was getting overwritten by the version in the dynamic config. Viper.Set overrides any existing value, so version should always be set to the running version regardless of what is in a config.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jul 24, 2025
@aphralG aphralG requested a review from a team as a code owner July 24, 2025 17:11
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Jul 24, 2025
@oCHRISo oCHRISo added the v2.x Issues and Pull Requests related to the major version v2 label Jul 28, 2025
@aphralG aphralG merged commit bf83b51 into dev-v2 Jul 29, 2025
129 of 132 checks passed
@aphralG aphralG deleted the fix-setting-agent-version branch July 29, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants