Added SNI support for JWT secrets retrieved from HTTPS URL #7500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
pdabelf5
previously approved these changes
Apr 3, 2025
AlexFenlon
previously approved these changes
Apr 3, 2025
|
@fabriziofiorucci can you remove the documentation updates unrelated to this change and we will try to get this merged. Thanks |
github-actions
bot
removed
the
documentation
|
@fabriziofiorucci can you plrease run |
AlexFenlon
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The current NGINX Ingress Controller implementation doesn't set the SNI field when fetching the JWT secret from an HTTPS URL. This breaks compatibility with idPs requiring SNI to be set.
This PR adds two directives to turn on SNI and set the hostname.
Checklist
Before creating a PR, run through this checklist and mark each as complete.