Add .NET 8.0 target #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dennis-gr
commented
Oct 17, 2025
dennis-gr
commented
- Replace .NET Core 2.0 with .NET 8, since the former has been EOL for a long time. Update AsyncGenerator to 0.22.0 for .NET 8 support. A couple more async test are being generated now, not sure why they haven't before but I'll take it :-)
- Also replace .NET 6 with 8 since it has reached EOL too,
- Additionally updated vulnerable packages in the test project to get rid of warnings, which prevent AsyncGenerator from running.
Removed .NET Core 2.0 target Updated AsyncGenerator to 0.22.0 Updated vulnerable packages
Merged
dennis-gr
commented
Oct 17, 2025
| <TargetFrameworks>net48;net6.0</TargetFrameworks> | ||
| <TargetFrameworks>net48;net8.0</TargetFrameworks> | ||
| <IsTestProject>true</IsTestProject> | ||
| <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization> |
There was a problem hiding this comment.
Re-enable usage of BinaryFormatter for the time being since it is only used in tests. Switch to something like MessagePack in the future.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.