upsert with modify example bug #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of the example `["INSERT INTO distributors (did, dname) VALUES (23, ?) ON CONFLICT (did) DO UPDATE SET dname = ?" "Foo Distributors" "EXCLUDED.dname || ' (formerly ' || d.dname || ')'"]` Will make dname set to varchar value which is exactly `"EXCLUDED.dname || ' (formerly ' || d.dname || ')'"` string, without value substitutions and concatenation being called. Need to use `sql/call` with `:CONCAT` (`:||` for some reason not added to `honeysql.format/infix-fns` maybe there is need to extend it in honeysql-postgres?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of the example
["INSERT INTO distributors (did, dname) VALUES (23, ?) ON CONFLICT (did) DO UPDATE SET dname = ?" "Foo Distributors" "EXCLUDED.dname || ' (formerly ' || d.dname || ')'"]Will make dname set to varchar value which is exactly
"EXCLUDED.dname || ' (formerly ' || d.dname || ')'"string, without value substitutions and concatenation being called. Need to usesql/callwith:CONCAT(:||for some reason not added tohoneysql.format/infix-fnsmaybe there is need to extend it in honeysql-postgres?)