feat: impl ConnectionManager as thread safe singleton #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maddin-619 Sorry Martin, I have to disappoint you. I moved to a commercial solution of an E/IP stack and do not use this solution anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of confusion about connecting multiple devices: #66
@Spritaro you were right. The library is already capable of handling multiple implicit connections simultaneously. We just used the library the wrong way by using multiple
ConnectionManagerinstances.This PR should prevent this missuse by converting the
ConnectionManagerinto a singleton.Because we use the singleton from within multiple threads I included some mutex to sync the member vars. I think of adding some compile options to disable the mutex for high performance single thread use cases.
What do you think @chruetli and @sriharshav?