Update Best Practices to include note about chown on COPY #2271
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing the advice on the best practice page, I was struggling to get my code to execute. After some debugging I realized that the
node
user did not have enough permissions to access my files.Motivation and Context
We should include explicit advice to easily give
node
user access to the files which most users will do via aCOPY
command in their Dockerfile. If they're doing it via a bind mount, the same advice will get them thinking about file permissions.Testing Details
As this is a docs change, no code tests are done, but I did confirm that the advice I'm adding does indeed work.
Note - I didn't run any of the tests (All new and existing tests passed) as I'm just making an edit to an
.md
file.Example Output(if appropriate)
Types of changes
Checklist