-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
build: use call command when calling python #60098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build: use call command when calling python #60098
Conversation
I do not think this is required. When I run |
Could be... Adding a video just to show that without the OS: Windows 10 Desktop.2025.10.06.-.10.23.04.08.mp4 |
I experience the same problem described in the issue, thanks for fixing it! |
Not sure if |
This is the main difference between my setup and yours. btw @marco-ippolito, since you're also seeing this, do you use the same Python setup? Since the build passed in the CI, I'm OK with the change. Failures are most likely flakes, so I've restarted the failed jobs. |
Yes I use pyenv for windows |
When running .\vcbuild.bat in PowerShell the file is stopping execution after calling
python configure %configure_flags%
even if python configure exits with a status of 0. Because the commands afterpython configure %configure_flags%
are never called you don't finish building and thus never get a out or release folder with node.exe in it.I am currently developing on Windows 10 and it looks like using
call python configure %configure_flags%
allows batch to continue after the python subroutine is finished