Skip to content

2025-10-20, Version 22.21.0 'Jod' (LTS) #60230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 90 commits into from
Oct 20, 2025
Merged

2025-10-20, Version 22.21.0 'Jod' (LTS) #60230

merged 90 commits into from
Oct 20, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 12, 2025 •
edited by aduh95
Loading

Notable Changes

  • [1486fedea1] - (SEMVER-MINOR) cli: add --use-env-proxy (Joyee Cheung) #59151
  • [bedaaa11fc] - (SEMVER-MINOR) http: support http proxy for fetch under NODE_USE_ENV_PROXY (Joyee Cheung) #57165
  • [af8b5fa29d] - (SEMVER-MINOR) http: add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824
  • [42102594b1] - (SEMVER-MINOR) http,https: add built-in proxy support in http/https.request and Agent (Joyee Cheung) #58980
  • [686ac49b82] - (SEMVER-MINOR) src: add percentage support to --max-old-space-size (Asaf Federman) #59082
Commits
  • [a71dd592e3] - benchmark: calibrate config dgram multi-buffer (Bruno Rodrigues) #59696
  • [16c4b466f4] - benchmark: calibrate config cluster/echo.js (Nam Yooseong) #59836
  • [53cb9f3b6c] - build: add the missing macro definitions for OpenHarmony (hqzing) #59804
  • [ec5290fe01] - build: do not include custom ESLint rules testing in tarball (Antoine du Hamel) #59809
  • [1486fedea1] - (SEMVER-MINOR) cli: add --use-env-proxy (Joyee Cheung) #59151
  • [1f93913446] - crypto: use return await when returning Promises from async functions (Renegade334) #59841
  • [f488b2ff73] - crypto: use async functions for non-stub Promise-returning functions (Renegade334) #59841
  • [aed9fd5ac4] - crypto: avoid calls to promise.catch() (Renegade334) #59841
  • [37c2d186f0] - deps: update amaro to 1.1.4 (pmarchini) #60044
  • [28aea13419] - deps: update archs files for openssl-3.5.4 (Node.js GitHub Bot) #60101
  • [ddbc1aa0bb] - deps: upgrade openssl sources to openssl-3.5.4 (Node.js GitHub Bot) #60101
  • [badbba2da9] - deps: update googletest to 50b8600 (Node.js GitHub Bot) #59955
  • [48aaf98a08] - deps: update archs files for openssl-3.5.3 (Node.js GitHub Bot) #59901
  • [e02a562ea6] - deps: upgrade openssl sources to openssl-3.5.3 (Node.js GitHub Bot) #59901
  • [7e0e86cb92] - deps: upgrade npm to 10.9.4 (npm team) #60074
  • [91dda5facf] - deps: update undici to 6.22.0 (Matteo Collina) #60112
  • [3a3220a2f0] - dgram: restore buffer optimization in fixBufferList (Yoo) #59934
  • [09bdcce6b8] - diagnostics_channel: fix race condition with diagnostics_channel and GC (Ugaitz Urien) #59910
  • [b3eeb3bd13] - doc: provide alternative to url.parse() using WHATWG URL (Steven) #59736
  • [1ddaab1904] - doc: mention reverse proxy and include simple example (Steven) #59736
  • [3b3b71e99c] - doc: mark .env files support as stable (Santeri Hiltunen) #59925
  • [d37f67d1bd] - doc: remove optional title prefixes (Aviv Keller) #60087
  • [ca2dff63f9] - doc: fix typo on child_process.md (Angelo Gazzola) #60114
  • [3fca564a05] - doc: add automated migration info to deprecations (Augustin Mauroy) #60022
  • [4bc366fc16] - doc: use "WebAssembly" instead of "Web Assembly" (Tobias Nießen) #59954
  • [4808dbdd9a] - doc: fix typo in section on microtask order (Tobias Nießen) #59932
  • [d6e303d645] - doc: update V8 fast API guidance (René) #58999
  • [0a3a3f729e] - doc: add security escalation policy (Ulises Gascón) #59806
  • [8fd669c70d] - doc: type improvement of file http.md (yusheng chen) #58189
  • [9833dc6060] - doc: rephrase dynamic import() description (Nam Yooseong) #59224
  • [2870a73681] - doc,crypto: update subtle.generateKey and subtle.importKey (Filip Skokan) #59851
  • [85818db93c] - fs,win: do not add a second trailing slash in readdir (Gerhard Stöbich) #59847
  • [bedaaa11fc] - (SEMVER-MINOR) http: support http proxy for fetch under NODE_USE_ENV_PROXY (Joyee Cheung) #57165
  • [af8b5fa29d] - (SEMVER-MINOR) http: add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824
  • [758271ae66] - http: optimize checkIsHttpToken for short strings (방진혁) #59832
  • [42102594b1] - (SEMVER-MINOR) http,https: add built-in proxy support in http/https.request and Agent (Joyee Cheung) #58980
  • [a33ed9bf96] - inspector: ensure adequate memory allocation for Binary::toBase64 (René) #59870
  • [34c686be2b] - lib: update inspect output format for subclasses (Miguel Marcondes Filho) #59687
  • [12e553529c] - lib: add source map support for assert messages (Chengzhong Wu) #59751
  • [d2a70571f8] - lib,src: refactor assert to load error source from memory (Chengzhong Wu) #59751
  • [20a9e86b5d] - meta: move Michael to emeritus (Michael Dawson) #60070
  • [c591cca15c] - meta: bump github/codeql-action from 3.30.0 to 3.30.5 (dependabot[bot]) #60089
  • [090ba141b1] - meta: bump codecov/codecov-action from 5.5.0 to 5.5.1 (dependabot[bot]) #60091
  • [a0ba6884a5] - meta: bump actions/stale from 9.1.0 to 10.0.0 (dependabot[bot]) #60092
  • [0feca0c541] - meta: bump actions/setup-node from 4.4.0 to 5.0.0 (dependabot[bot]) #60093
  • [7cd2b42d18] - meta: bump step-security/harden-runner from 2.12.2 to 2.13.1 (dependabot[bot]) #60094
  • [1f3b9d66ac] - meta: bump actions/cache from 4.2.4 to 4.3.0 (dependabot[bot]) #60095
  • [0fedbb3de7] - meta: bump ossf/scorecard-action from 2.4.2 to 2.4.3 (dependabot[bot]) #60096
  • [04590b8267] - meta: bump actions/setup-python from 5.6.0 to 6.0.0 (dependabot[bot]) #60090
  • [2bf0a9318f] - meta: add .npmrc with ignore-scripts=true (Joyee Cheung) #59914
  • [e10dc7b81c] - module: allow overriding linked requests for a ModuleWrap (Chengzhong Wu) #59527
  • [2237142369] - module: link module with a module request record (Chengzhong Wu) #58886
  • [6d24b88fbc] - node-api: added SharedArrayBuffer api (Mert Can Altin) #59071
  • [4cc84c96f4] - node-api: make napi_delete_reference use node_api_basic_env (Jeetu Suthar) #59684
  • [e790eb6b50] - repl: fix cpu overhead pasting big strings to the REPL (Ruben Bridgewater) #59857
  • [99ea08dc43] - repl: add isValidParentheses check before wrap input (Xuguang Mei) #59607
  • [e4a4f63019] - sqlite: fix crash session extension callbacks with workers (Bart Louwers) #59848
  • [42c5544b97] - src: assert memory calc for max-old-space-size-percentage (Asaf Federman) #59460
  • [686ac49b82] - (SEMVER-MINOR) src: add percentage support to --max-old-space-size (Asaf Federman) #59082
  • [84701ff668] - src: clear all linked module caches once instantiated (Chengzhong Wu) #59117
  • [8e182e561f] - src: remove unnecessary Environment::GetCurrent() calls (Moonki Choi) #59814
  • [c9cde35c4d] - src: simplify is_callable by making it a concept (Tobias Nießen) #58169
  • [892b425ee1] - src: rename private fields to follow naming convention (Moonki Choi) #59923
  • [36b68db7f5] - src: reduce the nearest parent package JSON cache size (Michael Smith) #59888
  • [26b40bad02] - src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings (Moonki Choi) #59891
  • [34dcb7dc32] - src: create strings in FIXED_ONE_BYTE_STRING as internalized (Anna Henningsen) #59826
  • [4d748add05] - src: remove std::array overload of FIXED_ONE_BYTE_STRING (Anna Henningsen) #59826
  • [bb6fd7c2d1] - src: ensure v8::Eternal is empty before setting it (Anna Henningsen) #59825
  • [7a91282bf9] - src: use simdjson::pad (0hm☘️) #59391
  • [ba00875f01] - stream: use new AsyncResource instead of bind (Matteo Collina) #59867
  • [ebec3ef68b] - (SEMVER-MINOR) test: move http proxy tests to test/client-proxy (Joyee Cheung) #58980
  • [7067d79fb3] - test: mark sea tests flaky on macOS x64 (Richard Lau) #60068
  • [ca1942c9d5] - test: testcase demonstrating issue 59541 (Eric Rannaud) #59801
  • [660d57355e] - test,doc: skip --max-old-space-size-percentage on 32-bit platforms (Asaf Federman) #60144
  • [19a7b1ef26] - tls: load bundled and extra certificates off-thread (Joyee Cheung) #59856
  • [095e7a81fc] - tls: only do off-thread certificate loading on loading tls (Joyee Cheung) #59856
  • [c42c1204c7] - tools: fix tools/make-v8.sh for clang (Richard Lau) #59893
  • [b632a1d98d] - tools: skip test-internet workflow for draft PRs (Michaël Zasso) #59817
  • [6021c3ac76] - tools: copyedit build-tarball.yml (Antoine du Hamel) #59808
  • [ef005d0c9b] - typings: update 'types' binding (René) #59692
  • [28ef564ecd] - typings: remove unused imports (Nam Yooseong) #59880
  • [f88752ddb6] - url: replaced slice with at (Mikhail) #59181
  • [24c224960c] - url: add type checking to urlToHttpOptions() (simon-id) #59753
  • [f2fbcc576d] - util: fix debuglog.enabled not being present with callback logger (Ruben Bridgewater) #59858
  • [6277058e43] - vm: sync-ify SourceTextModule linkage (Chengzhong Wu) #59000
  • [5bf21a4309] - vm: explain how to share promises between contexts w/ afterEvaluate (Eric Rannaud) #59801
  • [312b33a083] - vm: "afterEvaluate", evaluate() return a promise from the outer context (Eric Rannaud) #59801
  • [1eadab863c] - win,tools: add description to signature (Martin Costello) #59877
  • [816e1befb1] - zlib: reduce code duplication (jhofstee) #57810

mcollina and others added 30 commits October 7, 2025 15:53
@mcollina
deps: update undici to 6.22.0
91dda5f 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #60112
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@npm-cli-bot
deps: upgrade npm to 10.9.4
7e0e86c 
PR-URL: #60074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@meixg
repl: add isValidParentheses check before wrap input
99ea08d 
PR-URL: #59607
Backport-PR-URL: #60066
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@legendecas
module: link module with a module request record
2237142 
When a module is being statically linked with module requests, if two
module requests with a same specifier but different attributes are
resolved to two modules, the module requests should be linked to these
two modules.

PR-URL: #58886
Backport-PR-URL: #60000
Refs: https://tc39.es/ecma262/#sec-HostLoadImportedModule
Refs: https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#how-would-this-proposal-work-with-caching
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@0hmX @aduh95
src: use simdjson::pad
7a91282 
PR-URL: #59391
Refs: #59389
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
tools: copyedit build-tarball.yml
6021c3a 
PR-URL: #59808
Refs: https://www.shellcheck.net/wiki/SC2006
Refs: https://www.shellcheck.net/wiki/SC2086
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
build: do not include custom ESLint rules testing in tarball
ec5290f 
PR-URL: #59809
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos @aduh95
tools: skip test-internet workflow for draft PRs
b632a1d 
PR-URL: #59817
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@legendecas @aduh95
lib,src: refactor assert to load error source from memory
d2a7057 
The source code is available from V8 API and assert can avoid reading
the source file from the filesystem and parse the file again.

PR-URL: #59751
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@legendecas @aduh95
lib: add source map support for assert messages
12e5535 
Map source lines in assert messages with cached source maps.

PR-URL: #59751
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@addaleax @aduh95
src: ensure v8::Eternal is empty before setting it
bb6fd7c 
V8 does not check this for us, but this is a requirement of the API.

PR-URL: #59825
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@meteorqz6 @aduh95
doc: rephrase dynamic import() description
9833dc6 
The description is updated to clarify that dynamic import() is
asynchronous, dynamic, and works in both CJS and ESM contexts.
The new phrasing also avoids implying it is the only method for
loading ES modules in CommonJS.

Fixes: #59077
PR-URL: #59224
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@simon-id @aduh95
url: add type checking to urlToHttpOptions()
24c2249 
PR-URL: #59753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@meteorqz6 @aduh95
benchmark: calibrate config cluster/echo.js
16c4b46 
PR-URL: #59836
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@JeetuSuthar @aduh95
node-api: make napi_delete_reference use node_api_basic_env
4cc84c9 
PR-URL: #59684
Refs: #59583
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
@addaleax @aduh95
src: remove std::array overload of FIXED_ONE_BYTE_STRING
4d748ad 
This overload was only used in one place, in a cold path, and in
particular in a place where the compiler would be able to generate
the exact same code using just a call to `.size()`.

PR-URL: #59826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@addaleax @aduh95
src: create strings in FIXED_ONE_BYTE_STRING as internalized
34dcb7d 
These string keys can generally be assumed to be long-lived.

PR-URL: #59826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@BridgeAR @aduh95
repl: fix cpu overhead pasting big strings to the REPL
e790eb6 
Pasting input should not trigger any completions and other
calculations. This is now handled by just writing the string to the
terminal in case the user is pasting. As soon as pasting is done,
the completions will be re-enabled.

Fixes: #40626
Fixes: #43343
PR-URL: #59857
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR @aduh95
util: fix debuglog.enabled not being present with callback logger
f2fbcc5 
The method returned by the callback is missing the .enabled property.
This is added in a consistent way that it also verifies that it's a
getter.

Fixes: #56676
PR-URL: #59858
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@samuel871211 @aduh95
doc: type improvement of file http.md
8fd669c 
`outgoingMessage.setHeader` and `outgoingMessage.getHeader` section

PR-URL: #58189
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Connormiha @aduh95
url: replaced slice with at
f88752d 
PR-URL: #59181
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@brunocroh @aduh95
benchmark: calibrate config dgram multi-buffer
a71dd59 
PR-URL: #59696
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@JinhyeokFang @aduh95
http: optimize checkIsHttpToken for short strings
758271a 
Use lookup table instead of regex for strings shorter than 10
characters to improve performance for common short header names
while maintaining compatibility.

PR-URL: #59832
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Renegade334 @aduh95
inspector: ensure adequate memory allocation for Binary::toBase64
a33ed9b 
PR-URL: #59870
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGascon @aduh95
doc: add security escalation policy
0a3a3f7 
PR-URL: #59806
Refs: openjs-foundation/cross-project-council#1588
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@meteorqz6 @aduh95
typings: remove unused imports
28ef564 
PR-URL: #59880
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mertcanaltin @aduh95
node-api: added SharedArrayBuffer api
6d24b88 
PR-URL: #59071
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@mcollina @aduh95
stream: use new AsyncResource instead of bind
ba00875 
The bind method uses ObjectDefineProperty that shows up
in flamegraphs. This changes it to avoid the utility.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #59867
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@iknoom @aduh95
src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings
26b40ba 
PR-URL: #59891
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@michaelsmithxyz @aduh95
src: reduce the nearest parent package JSON cache size
36b68db 
PR-URL: #59888
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheung @aduh95
http: support http proxy for fetch under NODE_USE_ENV_PROXY
bedaaa1 
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and
`NO_PROXY` environment variables during startup, and tunnels requests
over the specified proxy.

This currently only affects requests sent over `fetch()`. Support for
other built-in `http` and `https` methods is under way.

PR-URL: #57165
Refs: nodejs/undici#1650
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joyeecheung @aduh95
test: move http proxy tests to test/client-proxy
ebec3ef 
Rewrite to ESM to use TLA.
Also add a test to make sure case precedence is honored.
Refs: https://about.gitlab.com/blog/we-need-to-talk-no-proxy

PR-URL: #58980
Refs: #57872
Refs: #8381
Refs: #15620
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joyeecheung @aduh95
http,https: add built-in proxy support in http/https.request and Agent
4210259 
This patch implements proxy support for HTTP and HTTPS clients and
agents in the `http` and `https` built-ins`. When NODE_USE_ENV_PROXY
is set to 1, the default global agent would parse the
HTTP_PROXY/http_proxy, HTTPS_PROXY/https_proxy, NO_PROXY/no_proxy
settings from the environment variables, and proxy the requests
sent through the built-in http/https client accordingly.

To support this, `http.Agent` and `https.Agent` now accept a few new
options:

- `proxyEnv`: when it's an object, the agent would read and parse
  the HTTP_PROXY/http_proxy, HTTPS_PROXY/https_proxy, NO_PROXY/no_proxy
  properties from it, and apply them based on the protocol it uses
  to send requests. This option allows custom agents to
  reuse built-in proxy support by composing options. Global agents
  set this to `process.env` when NODE_USE_ENV_PROXY is 1.
- `defaultPort` and `protocol`: these allow setting of the default port
  and protocol of the agents. We also need these when configuring
  proxy settings and deciding whether a request should be proxied.

Implementation-wise, this adds a `ProxyConfig` internal class to handle
parsing and application of proxy configurations. The configuration
is parsed during agent construction. When requests are made,
the `createConnection()` methods on the agents would check whether
the request should be proxied. If yes, they either connect to the
proxy server (in the case of HTTP reqeusts) or establish a tunnel
(in the case of HTTPS requests) through either a TCP socket (if the
proxy uses HTTP) or a TLS socket (if the proxy uses HTTPS).

When proxying HTTPS requests through a tunnel, the connection listener
is invoked after the tunnel is established. Tunnel establishment uses
the timeout of the request options, if there is one. Otherwise it uses
the timeout of the agent.

If an error is encountered during tunnel establishment, an
ERR_PROXY_TUNNEL would be emitted on the returned socket. If the proxy
server sends a errored status code, the error would contain an
`statusCode` property. If the error is caused by timeout, the error
would contain a `proxyTunnelTimeout` property.

This implementation honors the built-in socket pool and socket limits.
Pooled sockets are still keyed by request endpoints, they are just
connected to the proxy server instead, and the persistence of the
connection can be maintained as long as the proxy server respects
connection/proxy-connection or persist by default (HTTP/1.1)

PR-URL: #58980
Refs: #57872
Refs: #8381
Refs: #15620
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joyeecheung @aduh95
cli: add --use-env-proxy
1486fed 
This does the same as NODE_USE_ENV_PROXY. When both are set,
like other options that can be configured from both sides,
the CLI flag takes precedence.

PR-URL: #59151
Fixes: #59100
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 added a commit that referenced this pull request Oct 18, 2025
@aduh95
2025-10-20, Version 22.21.0 'Jod' (LTS)
79055d7 
Notable changes:

cli:
  * (SEMVER-MINOR) add `--use-env-proxy` (Joyee Cheung) #59151
http:
  * (SEMVER-MINOR) support http proxy for fetch under `NODE_USE_ENV_PROXY` (Joyee Cheung) #57165
  * (SEMVER-MINOR) add `shouldUpgradeCallback` to let servers control HTTP upgrades (Tim Perry) #59824
http,https:
  * (SEMVER-MINOR) add built-in proxy support in `http`/`https.request` and `Agent` (Joyee Cheung) #58980
src:
  * (SEMVER-MINOR) add percentage support to `--max-old-space-size` (Asaf Federman) #59082

PR-URL: #60230
@aduh95 aduh95 force-pushed the v22.21.0-proposal branch from f1a42f7 to 79055d7 Compare October 18, 2025 22:35
@aduh95
2025-10-20, Version 22.21.0 'Jod' (LTS)
54b94e1 
Notable changes:

cli:
  * (SEMVER-MINOR) add `--use-env-proxy` (Joyee Cheung) #59151
http:
  * (SEMVER-MINOR) support http proxy for fetch under `NODE_USE_ENV_PROXY` (Joyee Cheung) #57165
  * (SEMVER-MINOR) add `shouldUpgradeCallback` to let servers control HTTP upgrades (Tim Perry) #59824
http,https:
  * (SEMVER-MINOR) add built-in proxy support in `http`/`https.request` and `Agent` (Joyee Cheung) #58980
src:
  * (SEMVER-MINOR) add percentage support to `--max-old-space-size` (Asaf Federman) #59082

PR-URL: #60230
@aduh95 aduh95 force-pushed the v22.21.0-proposal branch from 79055d7 to 54b94e1 Compare October 18, 2025 22:36
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2025 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/69815/
CITGM (v22.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3644/
CITGM (v22.21.0-proposal): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3646/
📦: https://ci-release.nodejs.org/job/iojs+release/11342/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69816/

@aduh95 aduh95 merged commit 54b94e1 into v22.x Oct 20, 2025
58 checks passed
@aduh95 aduh95 deleted the v22.21.0-proposal branch October 20, 2025 23:46
aduh95 added a commit that referenced this pull request Oct 20, 2025
@aduh95
Working on v22.21.1
ef9a6cd 
PR-URL: #60230
aduh95 added a commit that referenced this pull request Oct 20, 2025
@aduh95
2025-10-20, Version 22.21.0 'Jod' (LTS)
b9dedf4 
Notable changes:

cli:
  * (SEMVER-MINOR) add `--use-env-proxy` (Joyee Cheung) #59151
http:
  * (SEMVER-MINOR) support http proxy for fetch under `NODE_USE_ENV_PROXY` (Joyee Cheung) #57165
  * (SEMVER-MINOR) add `shouldUpgradeCallback` to let servers control HTTP upgrades (Tim Perry) #59824
http,https:
  * (SEMVER-MINOR) add built-in proxy support in `http`/`https.request` and `Agent` (Joyee Cheung) #58980
src:
  * (SEMVER-MINOR) add percentage support to `--max-old-space-size` (Asaf Federman) #59082

PR-URL: #60230
@aduh95 aduh95 mentioned this pull request Oct 20, 2025
Merged
5 tasks
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Oct 20, 2025
@aduh95
Blog: v22.21.0 release post
3db6d6a 
Refs: nodejs/node#60230
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Oct 21, 2025
@aduh95
Blog: v22.21.0 release post (#8247)
5264576 
Refs: nodejs/node#60230
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Oct 21, 2025
@aduh95
Blog: v22.21.0 release post (#8247)
02b7799 
Refs: nodejs/node#60230
aduh95 added a commit to nodejs/nodejs.org that referenced this pull request Oct 21, 2025
@aduh95
Blog: v22.21.0 release post (#8247)
6c49a09 
Refs: nodejs/node#60230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

@aduh95 aduh95

Labels

release Issues and PRs related to Node.js releases. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.