Skip to content

PR closed due to unresolved review loop #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

PR closed due to unresolved review loop #8021

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
56d4079
fix(docs): correct response structure comment in GET example
nitin-is-me Jul 25, 2025
1144797
fix(docs): explain top-level await usage and fallback in fetch example
nitin-is-me Jul 25, 2025
e85f008
fix(docs): handle streaming JSON parsing properly in fetch example, a…
nitin-is-me Jul 25, 2025
09bc47f
fix(docs): add comment explaining TextDecoder stream option
nitin-is-me Jul 25, 2025
bb28953
chore: fixed bracket and spacing in comment example
nitin-is-me Jul 25, 2025
d5354de
fix(docs): include dual cjs/esm tabs in fetch streaming examples
nitin-is-me Jul 25, 2025
3ec643c
fix(docs): revert unintended tab changes for separate PR
nitin-is-me Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions apps/site/pages/en/learn/getting-started/fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,17 @@ async function main() {
const data = await response.json();
console.log(data);
// returns something like:
// [
// {
// userId: 1,
// id: 1,
// title: 'sunt aut facere repellat provident occaecati excepturi optio reprehenderit',
// body: 'quia et suscipit\n' +
// 'suscipit recusandae consequuntur expedita et cum\n' +
// 'reprehenderit molestiae ut ut quas totam\n' +
// 'nostrum rerum est autem sunt rem eveniet architecto'
// }
// userId: 1,
// id: 1,
// title: 'sunt aut facere repellat provident occaecati excepturi optio reprehenderit',
// body: 'quia et suscipit\n' +
// 'suscipit recusandae consequuntur expedita et cum\n' +
// 'reprehenderit molestiae ut ut quas totam\n' +
// 'nostrum rerum est autem sunt rem eveniet architecto'
// }
// ]
}

main().catch(console.error);
Expand Down Expand Up @@ -108,10 +110,11 @@ async function streamOllamaCompletion(prompt) {
}

let partial = '';

const decoder = new TextDecoder();

for await (const chunk of body) {
partial += decoder.decode(chunk, { stream: true });
// Note: decoder.decode() with { stream: true } may buffer incomplete UTF-8 chunks.
Comment on lines 116 to +117
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant to the code snippet?

  1. comments go above the block

console.log(partial);
}

Expand All @@ -134,7 +137,6 @@ try {

```js
import { Writable } from 'stream';

import { stream } from 'undici';

async function fetchGitHubRepos() {
Expand All @@ -155,23 +157,21 @@ async function fetchGitHubRepos() {
return new Writable({
write(chunk, encoding, callback) {
buffer += chunk.toString();

callback();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added?

},
final(callback) {
try {
const json = JSON.parse(buffer);
console.log(
'Repository Names:',
json.map(repo => repo.name)
);
buffer = '';
} catch (error) {
console.error('Error parsing JSON:', error);
} finally {
console.log('Stream processing completed.');
callback();
}

callback();
},
final(callback) {
console.log('Stream processing completed.');
callback();
Comment on lines 169 to -174
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this demo is to showcase the callback, let's not change it to a try final

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with aviv here - sometimes we choose to show code concepts in isolation even if a production app would have far more rigor

},
});
}
Expand All @@ -181,4 +181,4 @@ async function fetchGitHubRepos() {
}

fetchGitHubRepos().catch(console.error);
```
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```