Skip to content

Conversation

akredalen
Copy link
Contributor

@akredalen akredalen commented Sep 19, 2025

  • Added polling toggle on first button (to include single-button hardware). This was done to avoid messaging traffic when not needed.
  • Updated button mapping.
  • Removed descriptor action from buttons. This is still available via shell.
  • Updated docs.

Note: all PTS tests are passed.

@NordicBuilder NordicBuilder added the doc-required PR must not be merged without tech writer approval. label Sep 19, 2025
@akredalen akredalen added ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. and removed doc-required PR must not be merged without tech writer approval. labels Sep 19, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 19, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: f1b9710ac7637ba67ad93418b12fce27f5c4ff0c

more details

sdk-nrf:

PR head: f1b9710ac7637ba67ad93418b12fce27f5c4ff0c
merge base: b1cee3e847ff9b3d049b35dd67223e8acb508ae2
target head (main): de22712c117fa866bdf697697e97230ce51bdd0d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── sensor_client
│  │  │  │  ├── README.rst
│  │  │  │  ├── src
│  │  │  │  │  │ model_handler.c

Outputs:

Toolchain

Version: 2b2cd9579a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:2b2cd9579a_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 12
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_mesh
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

@akredalen akredalen marked this pull request as ready for review September 19, 2025 10:39
@akredalen akredalen requested review from a team as code owners September 19, 2025 10:39
@akredalen akredalen added the doc-required PR must not be merged without tech writer approval. label Sep 19, 2025
@akredalen akredalen force-pushed the NCSDK-35407_mesh_sensor_cli_update_button_interface branch from 9929b0f to 10c14f1 Compare September 19, 2025 11:46
@NordicBuilder NordicBuilder removed the ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. label Sep 19, 2025
@akredalen akredalen force-pushed the NCSDK-35407_mesh_sensor_cli_update_button_interface branch from 10c14f1 to 4eae7c8 Compare September 19, 2025 12:13
Copy link
Contributor

@omkar3141 omkar3141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@akredalen akredalen force-pushed the NCSDK-35407_mesh_sensor_cli_update_button_interface branch from 4eae7c8 to 58e7f86 Compare September 19, 2025 14:58
@akredalen akredalen requested a review from peknis September 19, 2025 15:01
* Added polling toggle on first button. This was done to avoid
  messaging traffic when not needed.
* Updated button mapping.
* Removed descriptor action from buttons. This is still available
  via shell.
* Updated docs.

Signed-off-by: Stine Åkredalen <stine.akredalen@nordicsemi.no>
@akredalen akredalen force-pushed the NCSDK-35407_mesh_sensor_cli_update_button_interface branch from 58e7f86 to f1b9710 Compare September 22, 2025 09:57
@akredalen akredalen requested a review from peknis September 22, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants