Use LSP instead of legacy --ide-* parameters #207

AlexeyRaga · 2025-09-02T11:58:34Z

Description

Switch from using specific --ide-* legacy parameters to using a full LSP server (provided by nu --lsp).

In this mode the plugin will automatically detect capabilities that LSP provides and will enable/support appropriate feature set in the IDE.

In particular, renaming capability works in this mode, which addresses #206 and, likely, delivers other goodness.

fdncred · 2025-09-02T13:09:57Z

wow! thanks for this! I'd like to have a deprecation period and a fallback to the traditional ide commands set via configuration. meaning, it would be nice to default to your new code but have an option in the settings to switch back to ide-* mode. do you think that's possible?

AlexeyRaga · 2025-09-02T14:24:47Z

@fdncred

Maybe? I don't know... Having some sort of a switch in the configuration, etc...
I don't really know.
But why? To support ancient versions of nu that doesn't have --lsp in it? Or what would the reason be?

I think we have two simpler options:

publish the new major version. People who for whatever reason want to fallback to --ide commands can just use the previous version of the plugin.

The last time it updated was almost a year ago, so it is not like someone would be missing frequently coming updates etc.

Publish a pre-release version of a plugin and keep it pre-release for that "deprecation period". After then we could finally switch.

I think that any of these is simpler than having a mixed codebase with switching logic etc.

fdncred · 2025-09-02T15:13:12Z

But why?

My fear that there will be funky bugs and no one to support the changes. If you want to sign up to support bugs for a little while, let's go ahead and just land it and publish it after the nushell release (which is supposed to be today).

AlexeyRaga · 2025-09-02T22:52:06Z

I am fine with supporting bugs on the plugin side (because there is little-to-no code to support, it is all LSP ;) )

But to play it very safe, let's publish a pre-release version of the plugin. People can opt-in for the new version and with one click opt-out if something goes wrong.

This is literally how every other plugin does it, and how VSCode plugins life cycle is designed to be

We wait for a month or so, watch the feedback, and then make it as a main release.

Do you agree @fdncred ?

fdncred · 2025-09-02T23:24:40Z

Sounds good but I'm not sure how to make it pre-release.

AlexeyRaga · 2025-09-03T03:47:19Z

Docs say it is fairly easy, just by adding --pre-release parameter:

vsce package --pre-release
vsce publish --pre-release

Ref: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

fdncred · 2025-09-03T11:55:49Z

ok, thanks. i can try that. we just released nushell 0.107.0 so it's a good time for me to try and remember how to do this release.

fdncred · 2025-09-03T20:30:33Z

@AlexeyRaga I'm trying to test the latest main branch on Windows and am getting all kinds of errors. Any ideas?

[Error - 3:49:38 PM] Client Nushell Language Server: connection to server is erroring. Shutting down server.
[Error - 3:49:38 PM] Stopping server failed
Error: Client is not running and can't be stopped. It's current state is: starting
	at Fl.shutdown (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:8615)
	at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:8194)
	at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:44100)
	at Fl.handleConnectionError (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:13955)
	at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
[Error - 3:49:40 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Info  - 3:49:40 PM] Connection to server got closed. Server will restart.
true
[Error - 3:49:40 PM] Nushell Language Server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:41 PM] Client Nushell Language Server: connection to server is erroring. Shutting down server.
[Error - 3:49:41 PM] Stopping server failed
Error: Client is not running and can't be stopped. It's current state is: startFailed
	at Fl.shutdown (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:8615)
	at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:8194)
	at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:44100)
	at Fl.handleConnectionError (c:\Users\username\source\repos\forks\vscode-nushell-lang\out\extension.js:39:13955)
	at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
[Error - 3:49:43 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Info  - 3:49:43 PM] Connection to server got closed. Server will restart.
true
[Error - 3:49:43 PM] Nushell Language Server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:47 PM] Client Nushell Language Server: connection to server is erroring. Shutting down server.
[Error - 3:49:47 PM] Stopping server failed
Error: Client is not running and can't be stopped. It's current state is: startFailed
    at Fl.shutdown (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:914:19)
    at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:885:21)
    at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\node\main.js:150:22)
    at Fl.handleConnectionError (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:1146:18)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
[Error - 3:49:50 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Info  - 3:49:50 PM] Connection to server got closed. Server will restart.
true
[Error - 3:49:50 PM] Nushell Language Server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:50 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:50 PM] Client Nushell Language Server: connection to server is erroring. Shutting down server.
[Error - 3:49:50 PM] Stopping server failed
Error: Client is not running and can't be stopped. It's current state is: startFailed
    at Fl.shutdown (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:914:19)
    at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:885:21)
    at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\node\main.js:150:22)
    at Fl.handleConnectionError (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:1146:18)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
[Error - 3:49:53 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Info  - 3:49:53 PM] Connection to server got closed. Server will restart.
true
[Error - 3:49:53 PM] Nushell Language Server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:53 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:53 PM] Client Nushell Language Server: connection to server is erroring. Shutting down server.
[Error - 3:49:53 PM] Stopping server failed
Error: Client is not running and can't be stopped. It's current state is: startFailed
    at Fl.shutdown (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:914:19)
    at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:885:21)
    at Fl.stop (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\node\main.js:150:22)
    at Fl.handleConnectionError (c:\Users\username\source\repos\forks\vscode-nushell-lang\node_modules\vscode-languageclient\lib\common\client.js:1146:18)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
[Error - 3:49:55 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:55 PM] The Nushell Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
[Error - 3:49:55 PM] Nushell Language Server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097 
[Error - 3:49:55 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097

fdncred · 2025-09-03T21:29:02Z

I updated a bunch of deps and now am getting this, along with the other errors.

[Error - 4:25:36 PM] Client Nushell Language Server: connection to server is erroring.
Header must provide a Content-Length property.
{"hello, from env.nu\nhello, from config.nu\nhello, from defs.nu\ncontent-length":"578"}
Shutting down server.

If I run nu --lsp from the repl i get this. it looks like it's trying to send those prints via stdout

❯ nu --lsp
Hello, from env.nu
Hello, from config.nu
Hello, from defs.nu

fdncred · 2025-09-03T21:33:54Z

That's it. Those extra "prints" were sending that information to the LSP. If I comment them out it works. I wonder how to get around this?

fdncred · 2025-09-04T15:50:12Z

I figured out how to have my cake and eat it too. I can print -e from my config files and the lsp doesn't care since -e is on stderr. The popups are a little wonky though on built-ins. Not sure what the markdown is exactly.

fdncred · 2025-09-04T16:23:21Z

@AlexeyRaga The new version is published but I don't see the Switch to Pre-Release button. I did vsce package --pre-release but the vsco publish --pre-release has never worked for me. So, I just upload the vsix to the site. Seems like without this step no one will be able to easily use the new version. Any ideas on what to do?

If I uninstall, I can then install the pre-release version though.

AlexeyRaga · 2025-09-06T05:06:22Z

@fdncred I do have it, without having to uninstall etc:

Maybe it is some caching, or a VSCode required to restart, I don't know... But worked for me

fdncred · 2025-09-06T13:16:01Z

ok, glad it worked for someone. thanks for letting me know.

Use LSP instead of legacy --ide-* parameters

45966c1

AlexeyRaga force-pushed the use-lsp branch from 45bc7a1 to 45966c1 Compare September 2, 2025 12:24

fdncred merged commit 92a4208 into nushell:main Sep 3, 2025
1 check passed

AlexeyRaga deleted the use-lsp branch September 4, 2025 00:13

fdncred mentioned this pull request Sep 4, 2025

feat(lsp): support using new language server implementations #162

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use LSP instead of legacy --ide-* parameters #207

Use LSP instead of legacy --ide-* parameters #207

Uh oh!

AlexeyRaga commented Sep 2, 2025 •

edited

Loading

Uh oh!

fdncred commented Sep 2, 2025

Uh oh!

AlexeyRaga commented Sep 2, 2025 •

edited

Loading

Uh oh!

fdncred commented Sep 2, 2025 •

edited

Loading

Uh oh!

AlexeyRaga commented Sep 2, 2025 •

edited

Loading

Uh oh!

fdncred commented Sep 2, 2025

Uh oh!

AlexeyRaga commented Sep 3, 2025

Uh oh!

fdncred commented Sep 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

fdncred commented Sep 3, 2025 •

edited

Loading

Uh oh!

fdncred commented Sep 3, 2025 •

edited

Loading

Uh oh!

fdncred commented Sep 3, 2025

Uh oh!

fdncred commented Sep 4, 2025

Uh oh!

fdncred commented Sep 4, 2025 •

edited

Loading

Uh oh!

AlexeyRaga commented Sep 6, 2025

Uh oh!

fdncred commented Sep 6, 2025

Uh oh!

Uh oh!

Use LSP instead of legacy --ide-* parameters #207

Use LSP instead of legacy --ide-* parameters #207

Uh oh!

Conversation

AlexeyRaga commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

fdncred commented Sep 2, 2025

Uh oh!

AlexeyRaga commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdncred commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexeyRaga commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdncred commented Sep 2, 2025

Uh oh!

AlexeyRaga commented Sep 3, 2025

Uh oh!

fdncred commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fdncred commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdncred commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdncred commented Sep 3, 2025

Uh oh!

fdncred commented Sep 4, 2025

Uh oh!

fdncred commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexeyRaga commented Sep 6, 2025

Uh oh!

fdncred commented Sep 6, 2025

Uh oh!

Uh oh!

AlexeyRaga commented Sep 2, 2025 •

edited

Loading

AlexeyRaga commented Sep 2, 2025 •

edited

Loading

fdncred commented Sep 2, 2025 •

edited

Loading

AlexeyRaga commented Sep 2, 2025 •

edited

Loading

fdncred commented Sep 3, 2025 •

edited

Loading

fdncred commented Sep 3, 2025 •

edited

Loading

fdncred commented Sep 3, 2025 •

edited

Loading

fdncred commented Sep 4, 2025 •

edited

Loading