support erc1056 for did document #116
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to develop a ssi service using your package.
The id document of the ssi service I am developing will support "blockchainAccountId" rather than public key in the "verificationMethod" field based on the example of the link I attached below to support compatibility with the ac-1056 based DIDRegistry convention.
https://github.com/decentralized-identity/ethr-did-resolver/blob/master/doc/did-method-spec.md
https://identity.foundation/EcdsaSecp256k1RecoverySignature2020/
Therefore, I modified it to support the verification method generation function of Ecdsaecp256k1 RecoveryMethod2020 type to support that part of your package.
The code below is a logic that created a document using the code I modified :)
result :
{ "@context": [ "https://www.w3.org/ns/did/v1", "https://w3id.org/security/suites/secp256k1recovery-2020/v2" ], "assertionMethod": [ "did:ethr:0xb9c5714089478a327f09197987f16f9e5d936e8a#key-1" ], "id": "did:ethr:0xb9c5714089478a327f09197987f16f9e5d936e8a", "verificationMethod": [ { "blockchainAccountId": "eip155:1:0xb9c5714089478a327f09197987f16f9e5d936e8a", "controller": "did:ethr:0xb9c5714089478a327f09197987f16f9e5d936e8a", "id": "did:ethr:0xb9c5714089478a327f09197987f16f9e5d936e8a#key-1", "type": "EcdsaSecp256k1RecoveryMethod2020" } ] }