Add retries to slack webhook delivery #958
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Dickinson
force-pushed
the
andrew/admin-notification-retries
branch
from
453e273 to
ba0186a
Compare
Andrew-Dickinson
force-pushed
the
andrew/admin-notification-retries
branch
from
ba0186a to
db1b82d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 95.05% 95.06%
=======================================
Files 98 98
Lines 4245 4253 +8
=======================================
+ Hits 4035 4043 +8
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillNilges
approved these changes
Jul 1, 2025
Collaborator
WillNilges
left a comment
WillNilges
left a comment
There was a problem hiding this comment.
One small suggestion.
Collaborator
There was a problem hiding this comment.
Does this code run synchronously anywhere that having an exponential backoff like this could be a problem? What if we sent the slack messages to the celery worker?
If we want to have slack messages sent during a Join Form processing, for example, this could be problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Datadog logs are filled with errors delivering notifications to slack :(
I believe this is a result of rate limiting. This PR adds retries with exponential backoff to the notification delivery system