Add option to decode path parameters before validation #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing of OpenAPI validations, I found unpredictable results when anything but simple ASCII characters were used. For example,
maxLengthandpatternconstraints weren't working as expected. I traced this down to the way kin-openapi is setting up the mux, which leads to: https://github.com/gorilla/mux/blob/db9d1d0073d27a0a2d9a8c1bc52aa0af4374d265/regexp.go#L357-L359router.FindRoute()returns escaped/%-encoded path parameters, which means validations are running against those instead of the actual string. I can't think of a good reason why that would be preferred, but I left it as the default behavior for backward compatibility.If the user wants these parameters decoded, they can set
DecodePathParams: true.