Skip to content

Conversation

cc-matthias-m
Copy link

Hi,

With the last version of react-native (0.75.4), the package display a warning for a deprecated code :

 ERROR  Warning: A props object containing a "key" prop is being spread into JSX:
  let props = {key: someKey, indicator: ..., style: ..., source: ..., accessible: ..., accessibilityLabel: ...};
  <FitImage {...props} />
React keys must be passed directly to JSX without using spread:
  let props = {indicator: ..., style: ..., source: ..., accessible: ..., accessibilityLabel: ...};
  <FitImage key={someKey} {...props} />

So I create this PR to fix it. As you can see, it’s really a light commit.

This PR work with last react-native version and previous one.

Do you think create a new npm patch 0.0.23 to add this modification ?

Thanks for reading.

@ericpoulinnz
Copy link

@obipawan can this PR be merged in and a new release pushed out? Getting the same issue with React Native 0.76

@rafatrace
Copy link

Can we merge this and get a new version please?

1 similar comment
@RoiDayan1
Copy link

Can we merge this and get a new version please?

@lehresman
Copy link

We're running into this too. Can we get a new release with this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants