Skip to content

Conversation

lazy404
Copy link

@lazy404 lazy404 commented Jul 28, 2025

Window scaling is a big performance win for tftp, especially across higher latency links. This PR implements the rfc7440 and adds windowsize option tests using external client.

The tests are happy:

lazy@lima-default:~/test/async-tftp-rs$ cargo test -F external-client-tests --tests -- --include-ignored
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.23s
     Running unittests src/lib.rs (target/debug/deps/async_tftp-fbb33ca2e49fdb05)

running 20 tests
test parse::tests::nul_str ... ok
test parse::tests::u16_be ... ok
test tests::packet::check_blksize_boundaries ... ok
test tests::packet::check_ack ... ok
test tests::packet::check_data ... ok
test tests::packet::check_packet ... ok
test tests::packet::check_oack ... ok
test tests::packet::check_timeout_boundaries ... ok
test tests::packet::check_error ... ok
test tests::packet::check_rrq ... ok
test tests::packet::check_wrq ... ok
test tests::rrq::transfer_0_bytes ... ok
test tests::rrq::transfer_block ... ok
test tests::rrq::transfer_less_than_block ... ok
test tests::rrq::transfer_1mb ... ok
test tests::rrq::transfer_32mb ... ok
test tests::rrq::transfer_more_than_block ... ok
test tests::rrq::transfer_more_than_32mb ... ok
test tests::rrq::transfer_more_than_64mb ... ok
test tests::rrq::transfer_almost_32mb ... ok

test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 24.24s

@oblique
Copy link
Owner

oblique commented Jul 29, 2025

Hey thanks! Give me few days and I will review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants