spike: Experiment with chaining links together #3639

claremacrae · 2025-09-30T09:11:17Z

This is an experiment to aid discussion on:

Getting TasksFile out of Link object? #3627

It's purely so that a build is created, for users to experiment with this implementation and give feedback.

There is no intention to merge this branch to main.

Feedback

Please put any feedback in:

Getting TasksFile out of Link object? #3627

How to test this

Go to https://github.com/obsidian-tasks-group/obsidian-tasks/actions/runs/18124750481
Download and expand the file dist-verified file
You will now have a new Tasks distribution which you can add in to your main vault, or a test vault

The Changes

This adds:

task.file.propertyAsLink('property-name') - which returns the property as a Link or a null
Link.asFile() which returns a TasksFile representing the link destination, or null

For context, TasksFile is the type of task.file.

An example of use, based on 4 test files that I added in PR...

```tasks
filename includes chain_link

# TODO Make 'group by' detect if the object is a link, and group by its markdown

group by function 'Level 1 link: ' + \
    task.file.\
        propertyAsLink('link_to_file').markdown

group by function 'Level 2 link: ' + \
    task.file.\
        propertyAsLink('link_to_file').asFile().\
        propertyAsLink('link_to_file').markdown

group by function 'Level 3 link: ' + \
    task.file.\
        propertyAsLink('link_to_file').asFile().\
        propertyAsLink('link_to_file').asFile().\
        propertyAsLink('link_to_file').markdown

group by function 'Level 4 link: ' + \
    task.file.\
        propertyAsLink('link_to_file').asFile().\
        propertyAsLink('link_to_file').asFile().\
        propertyAsLink('link_to_file').asFile().\
        propertyAsLink('link_to_file').markdown

```

Copied from: #3627 (reply in thread)

…tyAsLinks()

…east

…ample

…kResolver

…he()

# Conflicts: # tests/Scripting/TasksFile.test.ts

… loaded yet This will make tests of Links easier to write, as we won't have to force the tests to manually pre-load files being linked to.

This makes chaining of asFile().propertyAsLink('some-name') more consistent and less confusing

Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com>

LinkResolver is now set up globally, so tests don't need to be resetting its global state.

…) override

…solver.setup.ts, if needed at all

…nkResolver.setup.ts

… needed

The file name has two spaces in, and the link was missing a closing ]

sonarqubecloud · 2025-10-03T21:04:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

claremacrae added 30 commits September 22, 2025 16:17

vault: Sample files for #3627 - with hooks disabled

00e64c4

Copied from: #3627 (reply in thread)

feat: Initial implementation of TasksFile.propertyAsLink() and proper…

dbc32a3

…tyAsLinks()

test: - Test link.destinationPath

aaf1d2c

feat: - Add Link.destinationFile - does not yet access metadata

6128fbe

refactor: . Slide line up

7239b97

refactor: . Inline app variable

31ff538

refactor: . Extract QueryRenderer.getFileCache()

8156b87

refactor: ! Add uninitialiased app member to LinkResolver

d57a540

refactor: ! Add setter and getter for Link.app

bda23a3

refactor: ! Make setter for Link.app explicit

cdf315e

refactor: ! In the built-plugin, allow LinkResolver to access app

7f2aaf2

refactor: . Extract app variable in QueryRenderer.getFileCache()

ea0ae1e

refactor: . Extract globalGetFileCache()

150a197

refactor: . Inline app variable

b4b55a9

refactor: . Move globalGetFileCache to CacheReader.ts

5dc73c7

feat: Teach Link.destinationFile() to read properties, in plugin at l…

30a5e06

…east

vault: Show how to use task.file.propertyAsLink() - no hooks

f10ec6c

vault: Show use of task.file.propertyAsLink() when no link

e3a1633

vault: Show alternative filtering option - no hook

72c3e35

vault: Use consistent quote characters

cfa5f80

vault: Fix 'yarn lint:markdown'

6f75fd5

vault: Use headings to group sections - and add simpler 'group by' ex…

72c6d9e

…ample

vault: Add section to show dataview equivalents

53edb85

vault: Add global filter to sample tasks from user

13935ac

refactor: ! Introduce manually-tested getFileCacheFn mechanism to Lin…

7de37f6

…kResolver

refactor: ! main.ts now sets up LinkResolver.getInstance().getFileCac…

c745558

…he()

refactor: ! Remove LinkResolver.app, as no longer needed

66cf68b

vault: Show how to get dataview to chain property values

f579873

Merge branch 'main' into discussion-3627

73a8097

# Conflicts: # tests/Scripting/TasksFile.test.ts

test: - Make MockDataLoader.findDataFromMarkdownPath() find files not…

1356ef0

… loaded yet This will make tests of Links easier to write, as we won't have to force the tests to manually pre-load files being linked to.

claremacrae added 5 commits September 30, 2025 09:42

refactor: . Rename Link.destinationFile() to asFile()

41b1a86

vault: . Rename Link.destinationFile() to asFile()

800d85f

test: . Update tests for rename of destinationFile to asFile

685cb82

refactor: - Make Link.asFile() a function instead of a getter

f44a907

This makes chaining of asFile().propertyAsLink('some-name') more consistent and less confusing

vault: Add demo of chaining links together

c752484

claremacrae added the type: internal Only regards development or contributing label Sep 30, 2025

claremacrae marked this pull request as draft September 30, 2025 09:12

claremacrae and others added 22 commits October 3, 2025 10:11

test: - Automatically set up LinkResolver for all tests

8d80230

Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com>

test: - Fix failing tests

e0a7c94

test: - Remove duplicate test

8beec1b

test: - Prepare to remove LinkResolver.resetGetFirstLinkpathDestFn

cff2127

LinkResolver is now set up globally, so tests don't need to be resetting its global state.

test: - Prepare to remove LinkResolver.resetGetFirstLinkpathDestFn

62bf347

LinkResolver is now set up globally, so tests don't need to be resetting its global state.

test: . Add explanatory comment explaining setGetFirstLinkpathDestFn(…

1773d92

…) override

test: ! Include the path in an MockDataLoader error message

9ed9c17

test: - We no longer need to reset LinkResolver - it's done in LinkRe…

1fa7f54

…solver.setup.ts, if needed at all

test: - We no longer need to configure LinkResolver - it's done in Li…

2d42e90

…nkResolver.setup.ts

test: - We no longer need to configure LinkResolver - it's done in Li…

73214be

…nkResolver.setup.ts

test: - remove LinkResolver.resetGetFirstLinkpathDestFn() - no longer…

44c33f9

… needed

test: - remove LinkResolver.resetGetFileCacheFn() - no longer needed

76e4525

test: Update jsdoc for LinkResolver

48ec486

test: - Move LinkResolver.setup.ts to same dir as LinkResolver.ts

3e03ee5

vault: Link.asFile() is a function now, instead of a getter

15dfbbe

vault: Fix broken line in sample file

a3f8402

The file name has two spaces in, and the link was missing a closing ]

vault: Show how to tabulate project status in a Base

493e2a0

vault: Remove confusing double space in file name

6b6e449

vault: Add views for active and idea notes

fab60a6

vault: Divide dataview examples out in to separate file

325f3cf

vault: Divide bases example out in to separate file

a8a1382

vault: Rename 'Homepage.md' to 'Homepage - Tasks.md'

645888f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

spike: Experiment with chaining links together #3639

spike: Experiment with chaining links together #3639

Uh oh!

claremacrae commented Sep 30, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

spike: Experiment with chaining links together #3639

Are you sure you want to change the base?

spike: Experiment with chaining links together #3639

Uh oh!

Conversation

claremacrae commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Feedback

How to test this

The Changes

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Quality Gate passed

Uh oh!

Uh oh!

claremacrae commented Sep 30, 2025 •

edited

Loading