Fix stack smash crashes on Linux

[asahilina]

Description

See: chromiumembedded/cef#3912
Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2379591

How Has This Been Tested?

Local test build

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[RytoEX]

cc @tytan652 @GeorgesStavracas

Is this fixing an issue currently in the wild? Want to gauge whether this needs to land in a 31.1.x release or if it can wait until a future major/minor release.

[tytan652]

It's not exclusive to 31.1 (earlier version have the issue) and will require to backport changes to CEF 127 to have NO_STACK_PROTECTOR defined and enable the decoration.

So in my opinion it can wait until a future major/minor release.

[asahilina]

The main issue is noise for distros that have coredumps/reporting (like Fedora). Other than that it seems to be harmless since the crashes only happen on process exit.

For the fedora RPMs I will push this patch in so it's fixed there, since otherwise users will get abrt popups and file bugs with us (I already got one). I can't say about the effect for other distros or through the official Flatpak. If this has been going on for a while and nobody has complained about it yet, maybe it's fine to wait?