Skip to content

Revert 5.3 AST Bump #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

Revert 5.3 AST Bump #599

merged 3 commits into from
Oct 6, 2025

Conversation

patricoferris
Copy link
Collaborator

This reverts the bump of the internal AST to 5.3.

The only slight difference is that I copied the approach @NathanReb took to adding the 5.3 pprintast module but applied it to the 5.2 pprintast module instead.

NathanReb
NathanReb reviewed Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the 0.36.1 and 0.36.2 changelog sections from our 0.36 branch as we now re-imported the features back into the main branch?

@patricoferris
Revert "Merge pull request ocaml-ppx#558 from patricoferris/5.3-bump"
8733d19 
This reverts the bump of the internal AST to 5.3.

This reverts commit 5c1f6e3, reversing
changes made to 53e4fa3.

Signed-off-by: Patrick Ferris <patrick@sirref.org>
@patricoferris
Reapply pprintast.ml from 0.36
9a348e6 
Signed-off-by: Patrick Ferris <patrick@sirref.org>
@patricoferris
Add 0.36.2 changelog
82c2100 
Signed-off-by: Patrick Ferris <patrick@sirref.org>
NathanReb
NathanReb approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's merge!

@patricoferris patricoferris merged commit 7974f28 into ocaml-ppx:main Oct 6, 2025
7 checks passed
@patricoferris patricoferris deleted the revert-5.3-bump branch October 6, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanReb NathanReb NathanReb approved these changes

@ceastlund ceastlund Awaiting requested review from ceastlund ceastlund is a code owner

@panglesd panglesd Awaiting requested review from panglesd panglesd is a code owner

@pitag-ha pitag-ha Awaiting requested review from pitag-ha pitag-ha is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patricoferris @NathanReb