Enhancement: Adjust binary file location (#535) #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunand Kamath <yadunand.kamath@gmail.com>
Signed-off-by: Yadunand Kamath <yadunand.kamath@gmail.com>
nautaa
reviewed
Jun 23, 2025
benchmark/CMakeLists.txt
Outdated
| @@ -12,5 +12,8 @@ FOREACH (F ${ALL_SRC}) | |||
| if(NOT ${prjName} STREQUAL "memtracer_performance_test") | |||
| TARGET_LINK_LIBRARIES(${prjName} observer_static oblsm) | |||
| endif() | |||
| if(${prjName} STREQUAL "memtracer_performance_test") | |||
There was a problem hiding this comment.
why only put memtracer_performance_test in UNITTEST_OUTPUT_PATH?
you can put all benchmark binary in benchmark file.
Signed-off-by: Yadunand Kamath <yadunand.kamath@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 55.21% 55.20% -0.01%
==========================================
Files 178 178
Lines 10338 10338
==========================================
- Hits 5708 5707 -1
- Misses 4630 4631 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yadunand-kamath thanks for your patience, and welcome to continued participation in contributing to the community, feel free to get in touch if you have any ideas :) |
nautaa
reviewed
Jun 26, 2025
Signed-off-by: Yadunand Kamath <yadunand.kamath@gmail.com>
Lisa67865
pushed a commit
to Lisa67865/miniob
that referenced
this pull request
Jul 20, 2025
Previously, all unittest files and binary executable files (such as observer/obclient) were put together in `build_*/bin` directory. After the enhancement, the binary executable files and the unittest files have been separated into the following directories respectively: - `build_*/bin` - `build_*/unittest` Issue Number: close oceanbase#535 ### After enhancement ``` > cd build_debug > ls bin/ clog_dump cpplings obclient oblsm_bench oblsm_cli observer > ls unittesttest/ CMakeFiles bplus_tree_log_entry_test codec_test integer_generator_test mem_pool_test ob_lsm_test pax_storage_test thread_pool_executor_test CTestTestfile.cmake bplus_tree_log_test common log_buffer_test mvcc_trx_log_test ob_skiplist_test persist_test Makefile bplus_tree_test composite_tuple_test log_entry_test ob_arena_test ob_table_test pidfile_test aggregate_hash_table_test buffer_pool_log_test disk_buffer_pool_test log_file_test ob_block_test ob_util_test record_manager_test arithmetic_operator_test catalog_test disk_log_handler_test log_test ob_bloomfilter_test oblsm ring_buffer_test bitmap_test chunk_test double_write_buffer_test lower_bound_test ob_compaction_test observer serializer_test bp_manager_test cmake_install.cmake expression_test md5_test ob_lru_cache_test parser_test simple_queue_test ``` --------- Signed-off-by: Yadunand Kamath <yadunand.kamath@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all unittest files and binary executable files (such as observer/obclient) were put together in
build_*/bindirectory.After the enhancement, the binary executable files and the unittest files have been separated into the following directories respectively:
build_*/binbuild_*/unittestIssue Number: close #535
After enhancement