Skip to content

Conversation

irapandey
Copy link

This PR is resolving issue #85
Made changes in documentation as well as powervc-certificate is optional

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @irapandey! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks-extras 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2024
@irapandey irapandey force-pushed the powervc-cert-optional branch from bd85cfb to 41c3eac Compare October 21, 2024 07:36
@varad-ahirwadkar
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@yussufsh
Copy link
Contributor

/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2024
@irapandey irapandey force-pushed the powervc-cert-optional branch from 58e8be6 to e0743c8 Compare October 21, 2024 09:32
@irapandey irapandey requested a review from yussufsh October 21, 2024 09:41
@irapandey
Copy link
Author

@varad-ahirwadkar - can you take a look?

@irapandey irapandey force-pushed the powervc-cert-optional branch 2 times, most recently from caf33f2 to 2cc1088 Compare December 2, 2024 11:06
@yussufsh
Copy link
Contributor

yussufsh commented Jan 9, 2025

/cc @aman4433

Signed-off-by: ira-pandey1 <ira.pandey1@ibm.com>
@irapandey irapandey force-pushed the powervc-cert-optional branch from cad6bbb to 1875288 Compare February 20, 2025 05:27
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: irapandey
Once this PR has been reviewed and has the lgtm label, please assign yussufsh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aman4433
Copy link

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@yussufsh
Copy link
Contributor

/unhold
If all comments are resolved then please mark them so.

@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants