WIP: feat: updates for 1.76.3, update PER DCs and update deprecated apis #546

prb112 · 2025-03-20T12:14:02Z

1.76.2 is needed due to CIS changes which cause a NIL pointer and are addressed in this release.

ppc64le-cloud-bot · 2025-03-20T12:14:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prb112
Once this PR has been reviewed and has the lgtm label, please assign yussufsh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ppc64le-cloud-bot · 2025-03-20T12:14:11Z

@prb112: PR is not mergeable.

The PR state is: behind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

prb112 · 2025-03-20T12:14:51Z

ocp.tf

-  # PER doc reference: https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per
-  is_per                  = contains(["dal10", "dal12", "fra04", "fra05", "wdc06", "wdc07", "mad02", "mad04", "sao01", "sao04"], var.ibmcloud_zone)
+  # PER doc reference: https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per#dcs-per
+  is_per                  = contains(["dal10", "dal12", "dal13", "dal14", "fra04", "fra05", "lon04", "lon06", "mad02", "mad04", "osa21", "sao01", "sao04", "syd04", "syd05", "tok04", "tor01", "wdc04", "wdc06", "wdc07"], var.ibmcloud_zone)


Update the Zones to match the latest ones

prb112 · 2025-03-20T12:15:12Z

ocp.tf

+  is_per                  = contains(["dal10", "dal12", "dal13", "dal14", "fra04", "fra05", "lon04", "lon06", "mad02", "mad04", "osa21", "sao01", "sao04", "syd04", "syd05", "tok04", "tor01", "wdc04", "wdc06", "wdc07"], var.ibmcloud_zone)
  create_cloud_connection = var.use_ibm_cloud_services && var.ibm_cloud_connection_name == "" && !local.is_per
-  tgw_network             = module.prepare.cloud_connection_name == "" ? data.ibm_pi_workspace.workspace.pi_workspace_details.crn : module.prepare.cloud_connection_name
+  tgw_network             = module.prepare.cloud_connection_name == "" ? data.ibm_pi_workspace.workspace.pi_workspace_details[0].crn : module.prepare.cloud_connection_name


pi_workspace_details is returned as a list, so we pick the first one.

prb112 · 2025-03-20T12:15:53Z

modules/1_prepare/versions.tf

    ibm = {
      source  = "IBM-Cloud/ibm"
-      version = "1.60.0"
+      version = "1.76.2"


Update versions to v1.76.2

prb112 · 2025-03-20T12:16:45Z

modules/1_prepare/prepare.tf

 }

-resource "ibm_pi_network_port" "bastion_vip" {
+resource "ibm_pi_network_interface" "bastion_vip" {


ibm_pi_network_port was replaced with ibm_pi_network_interface

yussufsh · 2025-03-20T16:08:36Z

modules/1_prepare/outputs.tf

 output "bastion_external_vip" {
  depends_on = [null_resource.bastion_init]
-  value      = local.bastion_count > 1 ? ibm_pi_network_port.bastion_internal_vip[0].public_ip : ""
+  value      = local.bastion_count > 1 ? ibm_pi_network_interface.bastion_internal_vip[0].ip_address : ""


This will be a problem in ssh command output, DNS host entries, wildcard DNS. Somehow can we get the public IP from network?

Hey @yussufsh

I looked at the terraform-provider-ibm, it's unclear if this is the public IP address. Further looking into the api, it's not clear the API network, instance et cetra is suitable for returning the public ip (I anticipate they built it for VPC entry into the PowerVS workspace).

I'll have to experiment it a bit. I'll do that on Monday.

Thanks,

Paul

prb112 · 2025-04-23T15:34:21Z

CI picked this branch up and built a cluster successfully - https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.18-ocp-e2e-powervs-ovn-multi-p-px/1914914717416034304/artifacts/ocp-e2e-powervs-ovn-multi-p-px/upi-install-powervs-cluster/build-log.txt

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

…Cloud/terraform-provider-ibm [v1.76.3] Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

…ublic network Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

…he internal dns Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025

ppc64le-cloud-bot requested review from sajauddin and yussufsh March 20, 2025 12:14

ppc64le-cloud-bot added the do-not-merge/non-mergeable label Mar 20, 2025

ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2025

prb112 commented Mar 20, 2025

View reviewed changes

yussufsh reviewed Mar 20, 2025

View reviewed changes

prb112 changed the title ~~WIP: feat: updates for 1.76.2, update PER DCs and update deprecated apis~~ WIP: feat: updates for 1.76.3, update PER DCs and update deprecated apis Mar 26, 2025

prb112 force-pushed the terraform-1.76.2-updates branch from 2c6f428 to 785c435 Compare March 26, 2025 12:57

ppc64le-cloud-bot added the do-not-merge/contains-merge-commits label Apr 23, 2025

prb112 force-pushed the terraform-1.76.2-updates branch 2 times, most recently from 77bb098 to 4f2abf4 Compare April 23, 2025 15:42

ppc64le-cloud-bot removed the do-not-merge/contains-merge-commits label Apr 23, 2025

prb112 added 4 commits April 23, 2025 11:43

feat: updates for 1.76.3, update PER DCs and update deprecated apis

0cb854d

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

build(deps): ibm/ocp4-upi-compute-powervs-ibmcloud is updated to IBM-…

3d5d2d2

…Cloud/terraform-provider-ibm [v1.76.3] Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: network was improperly the private network and switched to the p…

acf8229

…ublic network Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: add us-east to avoid branching for cloud_connections

1c7cd76

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

prb112 force-pushed the terraform-1.76.2-updates branch from 4f2abf4 to 1c7cd76 Compare April 23, 2025 15:43

prb112 added 6 commits May 14, 2025 14:37

fix: changed the default 9.9.9.9 to use 161.26.0.10; 161.26.0.11 as t…

ab66c43

…he internal dns Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

OpenShiftP-284: change to to account for the proper DNS setting

2fbd79a

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

OpenShiftP-284: change docs for ext_dns

b845b47

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: account for codeload issues

0108f48

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: conflict between python-unversioned-command

ccd1386

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: account for multiple dns_forwarders

0339343

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

prb112 added 7 commits July 14, 2025 08:09

fix: update to latest terraform v1.80.3

60fa66b

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: update to latest terraform v1.80.4

6e8b0fa

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: account for different delimiters for different networks

52113bf

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: dns format, need to fix ocp4-helpernode

93db56b

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: dns format, need to fix ocp4-helpernode

92a00c8

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: add delay when load balancers aren't yet ready

f7d46f6

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: adjust the api sync point

09f6a66

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

ppc64le-cloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2025

prb112 added 3 commits September 8, 2025 20:26

refactor: adjusted the escape of the shell

ba2de08

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: override the default timezone to utc

7961ea7

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

fix: missed conditional for force utc

043463a

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: feat: updates for 1.76.3, update PER DCs and update deprecated apis #546

WIP: feat: updates for 1.76.3, update PER DCs and update deprecated apis #546

Uh oh!

prb112 commented Mar 20, 2025 •

edited

Loading

Uh oh!

ppc64le-cloud-bot commented Mar 20, 2025

Uh oh!

ppc64le-cloud-bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

prb112 Mar 20, 2025

Uh oh!

prb112 Mar 20, 2025

Uh oh!

prb112 Mar 20, 2025

Uh oh!

prb112 Mar 20, 2025

Uh oh!

yussufsh Mar 20, 2025

Uh oh!

prb112 Mar 28, 2025

Uh oh!

prb112 commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WIP: feat: updates for 1.76.3, update PER DCs and update deprecated apis #546

Are you sure you want to change the base?

WIP: feat: updates for 1.76.3, update PER DCs and update deprecated apis #546

Uh oh!

Conversation

prb112 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ppc64le-cloud-bot commented Mar 20, 2025

Uh oh!

ppc64le-cloud-bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prb112 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

prb112 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

prb112 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

prb112 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

yussufsh Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

prb112 Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

prb112 commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

prb112 commented Mar 20, 2025 •

edited

Loading

ppc64le-cloud-bot commented Mar 20, 2025 •

edited

Loading