Feat(max_changes) : Add parameter to specify max number of changes #81
Conversation
There was a problem hiding this comment.
Good catch. I think I'd prefer to build up the full list of updates in the for loop, basically leave that unchanged, and instead convert the section where the update was sent to be a loop over batches of records.
See
for an example of this in practice. The batching doesn't have to be in a separate method, that's just how it was done there. It works out cleaner that way, avoiding the need to have two difference places where API calls are made and error handled.
octodns_bind/__init__.py
Outdated
| @@ -369,6 +369,7 @@ def __init__( | |||
| key_name=None, | |||
| key_secret=None, | |||
| key_algorithm=None, | |||
| max_changes=1000, | |||
There was a problem hiding this comment.
Would prefer to call this update_batch_size or something similar as max_changes sounds like it will limit the number of changes that can be made to the number set and leave the rest un-updated.
There was a problem hiding this comment.
You're right, it's cleaner to do it in a separated method.
I've implemented the _batch method and reworked the loop.
There was a problem hiding this comment.
Format has been run also to correct the ci.
|
Thanks |
When trying to push a big zone file with a huge amount of record, we face the issue :
dns.exception.TooBig: The DNS message is too big.In order to solve that, we need to perform changes by batch.
I've added this parameter to let user choose the number of records process per batch with default : 1000