Hasaa Onboarding #949

hasaa-odoo · 2025-09-15T14:40:32Z

Created the estate module and made it an app

robodoo · 2025-09-15T14:40:35Z

alialfie · 2025-09-15T15:18:19Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


End of file line missing

alialfie · 2025-09-15T15:19:42Z

estate/__manifest__.py

+    'depends' : [
+        'base'
+    ]
+}


End of file line missing

alialfie · 2025-09-15T15:29:05Z

estate/models/estate_property.py

+
+
+
+


Too many end of file lines haha

alialfie · 2025-09-15T15:29:19Z

estate/__manifest__.py

+        'base'
+    ]


Suggested change

'base'

]

'base',

],

alialfie · 2025-09-16T08:10:59Z

estate/security/ir.model.access.csv

@@ -0,0 +1,3 @@
+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+"estate_access_estate_property","access_estate_property","estate.model_estate_property","base.group_user",1,1,1,1


Suggested change

"estate_access_estate_property","access_estate_property","estate.model_estate_property","base.group_user",1,1,1,1

"access_estate_property","access.estate.property","model_estate_property","base.group_user",1,1,1,1

alialfie · 2025-09-16T08:13:07Z

estate/models/estate_property.py

+    garden_area = fields.Integer()
+    garden_orientation = fields.Selection(
+        string = 'Orientation',
+        selection = [('north','North'),('south','South'),('east','East'),('west','West')]


Suggested change

selection = [('north','North'),('south','South'),('east','East'),('west','West')]

selection = [

('north','North'),

('south','South'),

('east','East'),

('west','West'),

],

alialfie · 2025-09-16T08:13:38Z

estate/models/estate_property.py

@@ -0,0 +1,24 @@
+from odoo import fields, models
+
+class Property(models.Model):


Suggested change

class Property(models.Model):

class EstateProperty(models.Model):

alialfie · 2025-09-16T11:41:59Z

estate/models/estate_property.py

+            ('offer_accepted','Offer Accepted'),
+            ('sold','Sold'),
+            ('cancelled','Cancelled'),
+        ]


alialfie · 2025-09-16T11:42:06Z

estate/models/estate_property.py

+            ('south','South'),
+            ('east','East'),
+            ('west','West'),
+        ]


alialfie · 2025-09-16T11:44:50Z

estate/views/estate_menus.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <menuitem id="estate_property_menu_root" name="Real Estate">
+        <menuitem id="estate_property_first_level_menu" name="Advertisements">


estate_property_advertisements_menu looks more clear

alialfie · 2025-09-16T11:45:04Z

estate/views/estate_menus.xml

+<odoo>
+    <menuitem id="estate_property_menu_root" name="Real Estate">
+        <menuitem id="estate_property_first_level_menu" name="Advertisements">
+            <menuitem id="test_model_menu_action" action="estate_property_action"/>


check the menu id

alialfie · 2025-09-17T12:52:49Z

estate/models/estate_property.py

+    _description = "Property annoucements"
+
+
+


Suggested change

Only two lines are expected

alialfie · 2025-09-17T12:53:06Z

estate/models/estate_property.py

@@ -0,0 +1,87 @@
+from odoo import api, fields, models, SUPERUSER_ID


Why are you importing SUPERUSER_ID? 🤔

alialfie · 2025-09-17T12:55:43Z

estate/views/estate_property_offer_views.xml

+<odoo>
+
+    <record id="estate_property_offer_view_form" model="ir.ui.view">
+        <field name="name">estate.property.offer.form</field>


Suggested change

<field name="name">estate.property.offer.form</field>

<field name="name">estate.property.offer.view.form</field>

The name and the id should match. Do this for the rest of the occurrences too please 🙏

alialfie · 2025-09-17T12:56:23Z

estate/views/estate_property_views.xml

+                <separator/>
+                <filter string="Available" name="state" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
+                <separator/>
+                <filter string="Postcode" name="postcode" context="{'group_by':'postcode'}"/>


group_by_postcode is better for the name and more clear

alialfie · 2025-09-17T12:57:09Z

estate/models/estate_property_offer.py

@@ -0,0 +1,44 @@
+from odoo import api, fields, models, SUPERUSER_ID


Same question about the import

alialfie · 2025-09-17T12:57:57Z

estate/models/estate_property_offer.py

+
+    partner_id = fields.Many2one("res.partner", string="Partner", required=True)
+    property_id = fields.Many2one("estate.property", string="Property", required=True)
+    validity = fields.Integer(default=7, string="Validity(days)", )


Suggested change

validity = fields.Integer(default=7, string="Validity(days)", )

validity = fields.Integer(default=7, string="Validity(days)")

No need for the comma here since it's on the same line

alialfie · 2025-09-17T12:58:25Z

estate/models/estate_property_offer.py

+
+    @api.depends("validity")
+    def _compute_deadline(self):
+        for record in self:


Suggested change

for record in self:

for offer in self:

More clear

alialfie · 2025-09-17T13:00:29Z

estate/models/estate_property_offer.py

+
+    def _inverse_deadline(self):
+        for record in self:
+            default_creation_date = record.create_date if record.create_date else fields.Date.today()


Suggested change

default_creation_date = record.create_date if record.create_date else fields.Date.today()

default_creation_date = record.create_date or fields.Date.today()

Another way to do it

alialfie · 2025-09-17T13:01:35Z

estate/views/estate_menus.xml

+
+

Sync the spaces before the starting and closing odoo tag and the first menuitem

…rom chapter 9

hasaa Chapter 2 Onboarding

eaa05f6

hasaa Chapter 3 Onboarding

a07a103

hasaa-odoo changed the title ~~Hasaa - Chapter 2 Onboarding~~ Hasaa Onboarding Sep 15, 2025

hasaa-odoo changed the base branch from 18.0 to 19.0 September 15, 2025 15:17

alialfie reviewed Sep 15, 2025

View reviewed changes

hasaa-odoo added 3 commits September 16, 2025 09:12

fixed the end of files - added suggestions - chapter 3

70f1e3c

fixed all the end of files ( forget some files in the last commit)

3eee5f5

chapter 4 : Security

c403f37

alialfie reviewed Sep 16, 2025

View reviewed changes

Chapter 5

ee85e0b

alialfie reviewed Sep 16, 2025

View reviewed changes

hasaa-odoo added 4 commits September 16, 2025 15:26

chapter6

1b537a3

Chapter 7

8d346d5

Chapter 8

8c405d5

Chapter 9

e8af15f

alialfie reviewed Sep 17, 2025

View reviewed changes

chapter 10 and improved the logic of the accepte and refuse buttons f…

57e40cd

…rom chapter 9

-        'base'
-    ]
+        'base',
+    ],

		@@ -0,0 +1,3 @@
		"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
		"estate_access_estate_property","access_estate_property","estate.model_estate_property","base.group_user",1,1,1,1

	"estate_access_estate_property","access_estate_property","estate.model_estate_property","base.group_user",1,1,1,1
	"access_estate_property","access.estate.property","model_estate_property","base.group_user",1,1,1,1

		@@ -0,0 +1,24 @@
		from odoo import fields, models

		class Property(models.Model):

	class Property(models.Model):
	class EstateProperty(models.Model):

		@@ -0,0 +1,87 @@
		from odoo import api, fields, models, SUPERUSER_ID

	<field name="name">estate.property.offer.form</field>
	<field name="name">estate.property.offer.view.form</field>

		@@ -0,0 +1,44 @@
		from odoo import api, fields, models, SUPERUSER_ID

	validity = fields.Integer(default=7, string="Validity(days)", )
	validity = fields.Integer(default=7, string="Validity(days)")

	default_creation_date = record.create_date if record.create_date else fields.Date.today()
	default_creation_date = record.create_date or fields.Date.today()

Hasaa Onboarding #949

Are you sure you want to change the base?

Hasaa Onboarding #949

Uh oh!

Conversation

hasaa-odoo commented Sep 15, 2025

Uh oh!

robodoo commented Sep 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alialfie Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alialfie Sep 16, 2025 •

edited

Loading