Skip to content

Conversation

jepar-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Sep 15, 2025

Pull request status dashboard

Copy link

@alialfie alialfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

<menuitem id="estate_model_menu_action" action="estate_model_create"/>
</menuitem>
</menuitem>
</odoo>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an end of file line here

@@ -0,0 +1,2 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an end of file line here

Comment on lines +1 to +3
# -*- coding: utf-8 -*-
# Part of Odoo. See LICENSE file for full copyright and licensing details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

Comment on lines +1 to +2
# -*- coding: utf-8 -*-
# Part of Odoo. See LICENSE file for full copyright and licensing details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

garden_area = fields.Integer()
garden_orientation = fields.Selection(
string='Orientation',
selection=[('north', 'North'), ('south', 'South'),('east', 'East'),('west', 'West')],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation please, new line for each pair :D

garden_orientation = fields.Selection(
string='Orientation',
selection=[('north', 'North'), ('south', 'South'),('east', 'East'),('west', 'West')],
help="Orientation of the garden of the property")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="Orientation of the garden of the property")
help="Orientation of the garden of the property",
)

indentation

('offer_received','Offer Received'),
('offer_accepted','Offer Accepted'),
('sold','Sold'),
('canceled', 'Cancelled')],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('canceled', 'Cancelled')],
('canceled', 'Cancelled'),
],

description = fields.Text()
postcode = fields.Char()
date_availability = fields.Date(default=fields.Date.today() + relativedelta.relativedelta(months=3))
expected_price = fields.Float(required=True)
selling_price = fields.Float()
bedrooms = fields.Integer(default=2)
bedrooms = fields.Integer('Bedrooms',default=2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bedrooms = fields.Integer('Bedrooms',default=2)
bedrooms = fields.Integer('Bedrooms', default=2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants