-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add fragmented bind/alter-context auth support #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It still panics, but now Line 411 in 4a46d46
I'm sorry that I cannot provide you with an |
|
@rtpt-erikgeiser right, wrong max_size of packet calculation, i'm on it. |
|
@rtpt-erikgeiser tried with zero-pad. it seems like Microsoft doesn't support v5.1 sort of things. hence, added auto-adjustable bind size, please check if it works for you. |
|
also, you can control the size of the fragment manually (see WithFragmentSize option) |
f79030c to
7c69d9b
Compare
|
No it panics with [0:6123] for a slice of capacity 4096. Do I need to use |
7c69d9b to
a37876a
Compare
|
@rtpt-erikgeiser i've updated and checked end-to-end with auth-pad. it seems to be working for bind when we send more data than we set in max-xmit-frag. could you please double-check on your side. |
|
With the latest commit, it does not panic anymore, but I get |
|
@rtpt-erikgeiser thanks for the hint, will try to reproduce. i'm wondering if this is related to the issue: https://learn.microsoft.com/en-us/troubleshoot/windows-server/windows-security/kerberos-authentication-problems-if-user-belongs-to-groups (here it is said that maximum buffer for the ap request should be adjusted). |
add fragmented bind/alter-context support for auth trailers exceeding max negotiated size. (see: https://pubs.opengroup.org/onlinepubs/9629399/chap12.htm)
add boundary checks for packet encoding.
See: #82