protobuf upgrade #952
Open
protobuf upgrade #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavk23
commented
Nov 5, 2025
arnavk23
commented
- I regenerated from the BESS proto sources (the authoritative proto inputs) to ensure the generated Go code matches upstream definitions.
- I used the same generator versions as your Dockerfile (protoc-gen-go v1.36.10, protoc-gen-go-grpc v1.5.1) so runtime and generated code align.
- Recommendation : Merging pfcpiface: add parse-error diagnostics, safe handling, raw dump and test #950 before this pr.
…ploy_debug script Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
…(keeps letters, digits, '.', '-', '' and replaces everything else with ''). Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Co-authored-by: Gabriel Arrobo <gabriel.arrobo@intel.com> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
…nRegenerated .pb.go files from latest BESS protobufs using protoc + protoc-gen-go/protoc-gen-go-grpc.\n\nSigned-off-by: Arnav Kapoor <kapoorarnav43@gmail.com> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
Contributor
|
Thanks for opening this PR. Have you tested the changes? Do not we need to make changes also in the |
Contributor
Yes, this is clear :-) |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the protobuf-generated code to use newer generator versions (protoc-gen-go v1.36.10 and protoc-gen-go-grpc v1.5.1) and introduces several enhancements:
- Regenerated Go code from BESS proto sources using updated protoc generator versions
- Added robust error handling and debugging capabilities for PFCP message parsing failures
- Introduced a canonical
UnknownStringconstant to eliminate repeated string literals - Added comprehensive test coverage for PFCP message handling edge cases
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| pfcpiface/utils.go | Defines UnknownString constant for consistent "unknown" value representation |
| pfcpiface/messages_parse_test.go | New test file verifying PFCP message handler gracefully handles truncated messages |
| pfcpiface/messages.go | Enhanced error logging with address context, added PFCP dump functionality via environment variables, implemented pruning logic for dump directories |
| pfcpiface/datapath.go | Updated to use new UnknownString constant |
| pfcpiface/bess_pb/util_msg.pb.go | Regenerated with protoc-gen-go v1.36.10 - updated field ordering, unsafe package usage, and modern protobuf patterns |
| pfcpiface/bess_pb/service_grpc.pb.go | New gRPC service definitions generated with protoc-gen-go-grpc v1.5.1 |
| pfcpiface/bess_pb/ports/port_msg.pb.go | Regenerated with updated protoc versions and Intel copyright added |
| pfcpiface/bess_pb/error.pb.go | Regenerated with protoc-gen-go v1.36.10 |
| pfcpiface/bess.go | Updated to use new UnknownString constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| func RegisterBESSControlServer(s grpc.ServiceRegistrar, srv BESSControlServer) { | ||
| // If the following call pancis, it indicates UnimplementedBESSControlServer was |
There was a problem hiding this comment.
Corrected spelling of 'pancis' to 'panics'.
Suggested change
| // If the following call pancis, it indicates UnimplementedBESSControlServer was | |
| // If the following call panics, it indicates UnimplementedBESSControlServer was |
| GetModuleInfo(ctx context.Context, in *GetModuleInfoRequest, opts ...grpc.CallOption) (*GetModuleInfoResponse, error) | ||
| // / Connect two modules. | ||
| // / | ||
| // / Connect between m1's ogate and n2's igate (i.e., ackets sent to m1's ogate |
There was a problem hiding this comment.
Corrected spelling of 'ackets' to 'packets'.
Suggested change
| // / Connect between m1's ogate and n2's igate (i.e., ackets sent to m1's ogate | |
| // / Connect between m1's ogate and n2's igate (i.e., packets sent to m1's ogate |
| // / Connect two modules. | ||
| // / | ||
| // / Connect between m1's ogate and n2's igate (i.e., ackets sent to m1's ogate | ||
| // / will be fed to m2's igate). The oate can be connected to only one igate, |
There was a problem hiding this comment.
Corrected spelling of 'oate' to 'ogate'.
Suggested change
| // / will be fed to m2's igate). The oate can be connected to only one igate, | |
| // / will be fed to m2's igate). The ogate can be connected to only one igate, |
| DumpMempool(ctx context.Context, in *DumpMempoolRequest, opts ...grpc.CallOption) (*DumpMempoolResponse, error) | ||
| // / Send a command to the specified module instance. | ||
| // / | ||
| // / Each module type defines a list of modyle-specific commands, which |
There was a problem hiding this comment.
Corrected spelling of 'modyle-specific' to 'module-specific'.
Suggested change
| // / Each module type defines a list of modyle-specific commands, which | |
| // / Each module type defines a list of module-specific commands, which |
| // / | ||
| // / NOTE: There should be no running worker to run this command. | ||
| CreateModule(ctx context.Context, in *CreateModuleRequest, opts ...grpc.CallOption) (*CreateModuleResponse, error) | ||
| // / Destroy an exsting module |
There was a problem hiding this comment.
Corrected spelling of 'exsting' to 'existing'.
Suggested change
| // / Destroy an exsting module | |
| // / Destroy an existing module |
| GetModuleInfo(context.Context, *GetModuleInfoRequest) (*GetModuleInfoResponse, error) | ||
| // / Connect two modules. | ||
| // / | ||
| // / Connect between m1's ogate and n2's igate (i.e., ackets sent to m1's ogate |
There was a problem hiding this comment.
Corrected spelling of 'ackets' to 'packets'.
Suggested change
| // / Connect between m1's ogate and n2's igate (i.e., ackets sent to m1's ogate | |
| // / Connect between m1's ogate and n2's igate (i.e., packets sent to m1's ogate |
| // / Connect two modules. | ||
| // / | ||
| // / Connect between m1's ogate and n2's igate (i.e., ackets sent to m1's ogate | ||
| // / will be fed to m2's igate). The oate can be connected to only one igate, |
There was a problem hiding this comment.
Corrected spelling of 'oate' to 'ogate'.
Suggested change
| // / will be fed to m2's igate). The oate can be connected to only one igate, | |
| // / will be fed to m2's igate). The ogate can be connected to only one igate, |
| DumpMempool(context.Context, *DumpMempoolRequest) (*DumpMempoolResponse, error) | ||
| // / Send a command to the specified module instance. | ||
| // / | ||
| // / Each module type defines a list of modyle-specific commands, which |
There was a problem hiding this comment.
Corrected spelling of 'modyle-specific' to 'module-specific'.
Suggested change
| // / Each module type defines a list of modyle-specific commands, which | |
| // / Each module type defines a list of module-specific commands, which |
| // / | ||
| // / NOTE: There should be no running worker to run this command. | ||
| CreateModule(context.Context, *CreateModuleRequest) (*CreateModuleResponse, error) | ||
| // / Destroy an exsting module |
There was a problem hiding this comment.
Corrected spelling of 'exsting' to 'existing'.
Suggested change
| // / Destroy an exsting module | |
| // / Destroy an existing module |
| // / Destroy an exsting module | ||
| // / | ||
| // / If the module is connected to other modules' input/output gate, they are | ||
| // / disconnected first. All tasks created by the module will also be destoyed. |
There was a problem hiding this comment.
Corrected spelling of 'destoyed' to 'destroyed'.
Suggested change
| // / disconnected first. All tasks created by the module will also be destoyed. | |
| // / disconnected first. All tasks created by the module will also be destroyed. |
Contributor
|
Fixes #953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.