fix(unblob): unnecessary carving of padding in qnx elf file #1241
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
4248-unnecessary-carving-of-elf-file-in-qnx-firmware
branch
2 times, most recently
from
8d6a71a to
f9c08f4
Compare
qkaiser
added
enhancement
qkaiser
force-pushed
the
4248-unnecessary-carving-of-elf-file-in-qnx-firmware
branch
from
d5fb0b2 to
8d6a71a
Compare
qkaiser
force-pushed
the
4248-unnecessary-carving-of-elf-file-in-qnx-firmware
branch
from
8d6a71a to
682942d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some QNX binaries are padded with a 4kib of null bytes. There is no reason to carve them.
So this fix will look into the elf binary sections to identify if it a QNX binary and carve the file with padding included.