-
Notifications
You must be signed in to change notification settings - Fork 9
Update to Cadence v1.8.3 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
turbolent
wants to merge
1
commit into
main
Choose a base branch
from
auto-update-onflow-cadence-v1.8.3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Confirm intentionality of pseudo-versions for golang-lru and blst.
Lines 61 and 310 use pseudo-version timestamps rather than released versions:
fxamacker/golang-lru/v2 v2.0.0-20250716153046-22c8d17dc4eesupranational/blst v0.3.16-0.20250831170142-f48500c1fdbeThese appear to be development/patched versions rather than official releases. Verify that this is intentional and necessary for Flow's requirements, particularly since these are cryptographic libraries.
Also applies to: 310-310
🌐 Web query:
💡 Result:
Sources:
[1] supranational/blst releases.
[2] hashicorp/golang-lru releases.
Update cryptographic dependencies to stable releases instead of pseudo-versions.
The latest official release of
supranational/blstis v0.3.16 (released 19 Sep 2025), but go.mod pins a pseudo-version from 31 Aug 2025. The latest official release offxamacker/golang-lru/v2is v2.0.7 (released 29 Sep 2025), but go.mod pins a pseudo-version from 16 Jul 2025.Using pseudo-versions for cryptographic libraries introduces maintenance and security risks. Update both dependencies to their stable releases:
v2.0.7v0.3.16If pseudo-versions are intentional due to incompatibilities with stable releases, document the reason.
🤖 Prompt for AI Agents