feat: add methods to support asynchronous enumeration of paged responses #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a field test data based on concrete classes and enums from the sdk itself. Instead the fields returned are generic objects that represent a field data set you'd get back from the api. This way I can add additional fields to the dataset that demonstrate the FormulaOutputType enum contains incorrect values for date and number.
…ller.cs that include a formula field with each possible output type. These additional fields cause by the GetFieldsAsync and GetFieldsForAppAsync tests in OnspringClientFieldTests to fail because the OutputType values of Numeric and DateAndTime can't be deserialized to any of the existing FormulaOutputType enum values.
…e which is the actual value that the Onspring API will return for formula fields with their output type configured as date/time.
…which is the actual value that the Onspring API will return for formula fields with their output type configured as numeric. NOTE: All tests now passing again.
…ue. fix: modified response data in test controller to respond with proper OutputType value for list formula field.
…est FieldsController to verify deserializing works for survey delegation field
…eferences to latest versions
…ce of an OnspringRequest
…ation using IAsyncEnumerable
…numerable builders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for handling pagination of paged responses by leveraging the
IAsyncEnumerable<T>interface. It is meant to close #19.Note
This PR's branch was branched from a forked version of the SDK that includes the changes detailed in #18.
Changes
Features
Chores
Tests
Docs