AgentQnA: update instructions and env variable names for remote endpoints #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexsin368 <alex.sin@intel.com>
alexsin368
requested review from
ashahba,
lkk12014402,
minmin-intel and
XinyuYe-Intel
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull Request Overview
Update instructions and environment variable names to support remote endpoints in the AgentQnA service.
- Renamed the interpolated env var from
LLM_ENDPOINT_URLtoREMOTE_ENDPOINTincompose_remote.yaml - Extended README with new
REMOTE_ENDPOINTandmodelvariables and updated related instructions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AgentQnA/docker_compose/intel/cpu/xeon/compose_remote.yaml | Swapped ${LLM_ENDPOINT_URL} for ${REMOTE_ENDPOINT} in service environments |
| AgentQnA/README.md | Clarified remote endpoint setup, added REMOTE_ENDPOINT and model vars |
Comments suppressed due to low confidence (2)
AgentQnA/README.md:220
- [nitpick] Consider using an uppercase environment variable name (
MODEL) for consistency and clarity, since env vars are typically all-caps.
- `model` is the model card which may need to be overwritten depending on what it is set to `set_env.sh`.
36 tasks
Signed-off-by: alexsin368 <alex.sin@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>
amberjain1
reviewed
Jul 31, 2025
amberjain1
reviewed
Jul 31, 2025
alexsin368
force-pushed
the
agentqna-remote-endpoint
branch
from
f7e9c7d to
2870386
Compare
Signed-off-by: alexsin368 <alex.sin@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>
chensuyue
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update instructions and environment variables names for remote endpoints.
Issues
#1973
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Documentation change only.