-
Notifications
You must be signed in to change notification settings - Fork 309
Fix ffmpeg dependency issue in gradio docker images #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: letonghan <letong.han@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes ffmpeg dependency issues in Gradio Docker images by simplifying the ffmpeg installation approach. Instead of downloading and manually installing a static build from johnvansickle.com, the PR switches to using the standard ffmpeg package from the apt repository.
- Removes complex manual ffmpeg static build installation
- Adds ffmpeg as a standard apt package dependency
- Simplifies the Docker build process by eliminating custom download and extraction steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
MultimodalQnA/ui/docker/Dockerfile | Replaces manual ffmpeg static build installation with apt package |
CodeGen/ui/docker/Dockerfile.gradio | Replaces manual ffmpeg static build installation with apt package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine => approved.
However, one CI test fails to ASR service timeout. Could you rebase this to main
so test gets re-run?
Image size "collect-comments" CI test lists noticeable image size improvement:
|
Thanks @eero-t . All CI tests passed now. |
Signed-off-by: letonghan <letong.han@intel.com> Co-authored-by: chen, suyue <suyue.chen@intel.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
Description
Fix ffmpeg dependency issue in gradio docker images
Issues
Fixes #2089
Type of change
Dependencies
update download version of ffmpeg
Tests
Describe the tests that you ran to verify your changes.