Skip to content

Conversation

letonghan
Copy link
Collaborator

Description

Fix ffmpeg dependency issue in gradio docker images

Issues

Fixes #2089

Type of change

  • Others (enhancement, documentation, validation, etc.)

Dependencies

update download version of ffmpeg

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: letonghan <letong.han@intel.com>
@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 06:01
Copy link

github-actions bot commented Jul 31, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes ffmpeg dependency issues in Gradio Docker images by simplifying the ffmpeg installation approach. Instead of downloading and manually installing a static build from johnvansickle.com, the PR switches to using the standard ffmpeg package from the apt repository.

  • Removes complex manual ffmpeg static build installation
  • Adds ffmpeg as a standard apt package dependency
  • Simplifies the Docker build process by eliminating custom download and extraction steps

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
MultimodalQnA/ui/docker/Dockerfile Replaces manual ffmpeg static build installation with apt package
CodeGen/ui/docker/Dockerfile.gradio Replaces manual ffmpeg static build installation with apt package

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine => approved.

However, one CI test fails to ASR service timeout. Could you rebase this to main so test gets re-run?

@eero-t
Copy link
Contributor

eero-t commented Aug 11, 2025

Image size "collect-comments" CI test lists noticeable image size improvement:

MultimodalQnA/ui/docker/Dockerfile resulted in a change in the image size from 1899 -> 1750 MB (diff: -149 MB)

@letonghan
Copy link
Collaborator Author

Looks fine => approved.

However, one CI test fails to ASR service timeout. Could you rebase this to main so test gets re-run?

Thanks @eero-t . All CI tests passed now.

@letonghan letonghan merged commit f084b35 into opea-project:main Aug 12, 2025
40 of 41 checks passed
alexsin368 pushed a commit to alexsin368/GenAIExamples that referenced this pull request Aug 13, 2025
Signed-off-by: letonghan <letong.han@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Old, static FFmpeg GPLv3 Git snapshot used for gradio images
5 participants