Skip to content

feat: introduce Visualisation Platform data as second data source #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 113 commits into from
Oct 3, 2025
Merged

feat: introduce Visualisation Platform data as second data source #117

merged 113 commits into from
Oct 3, 2025

Conversation

tgilon
Copy link
Member

@tgilon tgilon commented Sep 26, 2025 •
edited
Loading

This PR builds on #73.

Changes proposed in this Pull Request

As some of the Open-TYNDP data doesn't match the original benchmarking dataset introduced in #73 (from the Scenarios package), an additional data source has been is added to assess the quality of the Open-TYNDP outputs. The data was been extracted directly from the TYDNP 2024 Visualisation Platform.

Open Issues

  • Identify which of the two data sources (TYNDP 2024 Report Figures Data package or Visualisation Platform) is correct.

Notes

Here is an illustration using Open-TYNDP data introduced in #115 . In fact, this PR supports the validation of #115 .

image

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Changes in configuration options are added in config/test/*.yaml.
  • OET license identifier is added to all edited or newly created code files.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.
  • Major features are listed in README and doc/index.rst.

tgilon and others added 30 commits July 17, 2025 12:14
@tgilon
feat: introduce benchmarking configuration files
892a695
@tgilon
feat: introduce benchmarking rules
811384e
@tgilon
refactor: indent to keep all the configurations under benchmarking
f79a926
@tgilon
Merge branch 'master' into feat/31-benchmarks
00bc467 
 Conflicts:
	Snakefile
	rules/collect.smk
@tgilon
fix: resolve merge conflicts
eb36ecb
@tgilon
refactor: rename files according to naming convention
2ee5a28
@tgilon
feat: implement retrieve_tyndp_benchmark rule
9c2b91c
@tgilon
feat: implement clean_tyndp_benchmark rule
0f9e1c5
@tgilon
Merge branch 'master' into feat/31-benchmarks
1626eed
@tgilon
doc: use new SPDX license header
4f07f4c
@tgilon
feat: implement build_benchmark rule
215e297
@tgilon
feat: implement make_benchmark rule
1837838
@tgilon
Merge branch 'master' into feat/31-benchmarks
12e4ec8 
 Conflicts:
	rules/collect.smk
@tgilon
feat: add growth error
415480d
@tgilon
fix: validate climate year, improve config, documentation and style
285f73d
@tgilon
fix: improve missing indicator
02acd7b
@tgilon
refactor: remove method options
26e8ee3
@tgilon
doc: improve type hints
6bcab93
@daniel-rdt
fix: remove snakemake reference inside function
498ad63
@tgilon
Merge branch 'master' into feat/31-benchmarks
15f2948
@tgilon @daniel-rdt
Apply suggestions from code review
ab3a284 
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fe81f80 
for more information, see https://pre-commit.ci
@tgilon
Merge remote-tracking branch 'master' into feat/31-benchmarks-i
cd135c1
@tgilon
feat: generalise tyndp data retrieval
4f090e7
@tgilon
refactor: move the entire benchmarking configuration to default
82a2110
@tgilon
fix: address unknown climate year case for generation profiles in bui…
e6183ea 
…ld_benchmarks
@tgilon
refactor: move SCENARIO_DICT to _helpers
4a47050
@tgilon
refactor: remove unused parameter
1f4fc27
@tgilon
refactor: clarify difference between build_benchmark and make_benchmark
8434487
@tgilon
fix: fix variable name changes
737342a
daniel-rdt
daniel-rdt requested changes Oct 2, 2025
View reviewed changes
@daniel-rdt
Copy link
Member

daniel-rdt commented Oct 2, 2025 •
edited
Loading

@tgilon I forgot to add the review summary, so here as a follow-up:
The PR looks largely good, we have one problem though with mismatched climate years, that is causing the CI to fail. I made a comment pointing out the location. Otherwise, I have only minor comments!

daniel-rdt and others added 10 commits October 2, 2025 17:30
@tgilon tgilon requested a review from daniel-rdt October 2, 2025 22:04
@daniel-rdt
Copy link
Member

LGTM!

Base automatically changed from feat/31-benchmarks to master October 3, 2025 10:07
@tgilon
Merge branch 'master' into feat/vp-data
4b05539 
 Conflicts:
	README.md
	doc/benchmarking.rst
	doc/data-retrieval.rst
	doc/img/tyndp/benchmarking_workflow.png
	doc/index.rst
	doc/release_notes.rst
	rules/benchmarking.smk
	rules/collect.smk
	rules/retrieve.smk
	scripts/make_benchmark.py
	scripts/plot_benchmark.py
@tgilon tgilon merged commit fd35e44 into master Oct 3, 2025
5 checks passed
@tgilon tgilon deleted the feat/vp-data branch October 3, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-rdt daniel-rdt daniel-rdt approved these changes

@coroa coroa Awaiting requested review from coroa

Assignees

@tgilon tgilon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgilon @daniel-rdt