feat: add configuration property to define which key is used if a string without equals is used as a selector

[aepfli]

This pull request introduces a significant enhancement to how flag selectors are parsed, particularly for simplified selector strings that do not explicitly define a key-value pair. By adding a configurable fallback key, the system gains increased flexibility, allowing users to customize the interpretation of such selectors beyond the default 'source' key. This change improves the adaptability of the flag evaluation logic without breaking backward compatibility.

Highlights

• Configurable Selector Fallback: Introduced a new configuration property (selector-fallback-key) that allows defining which key is used when a selector string without an equals sign is provided (e.g., "myValue" instead of "key=myValue").
• Enhanced Selector Parsing: The internal Selector and expressionToMap functions now support this configurable fallback, defaulting to the existing sourceIndex if no fallback key is specified.
• Store Initialization Refactor: The store.NewStore function now accepts a StoreConfig struct, encapsulating source and the new selector fallback key, leading to cleaner initialization.
• Command-Line Option: A new --selector-fallback-key flag has been added to the flagd command to allow users to specify this fallback behavior via command-line arguments.

[netlify]

✅ Deploy Preview for polite-licorice-3db33c ready!

Name	Link
🔨 Latest commit	54989a2
🔍 Latest deploy log	https://app.netlify.com/projects/polite-licorice-3db33c/deploys/68c05baeb7ebfc00088af534
😎 Deploy Preview	https://deploy-preview-1798--polite-licorice-3db33c.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[gemini-code-assist]

Summary of Changes

Hello @aepfli, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to how flag selectors are parsed, particularly for simplified selector strings that do not explicitly define a key-value pair. By adding a configurable fallback key, the system gains increased flexibility, allowing users to customize the interpretation of such selectors beyond the default 'source' key. This change improves the adaptability of the flag evaluation logic without breaking backward compatibility.

Highlights

• Configurable Selector Fallback: Introduced a new configuration property (selector-fallback-key) that allows defining which key is used when a selector string without an equals sign is provided (e.g., "myValue" instead of "key=myValue").
• Enhanced Selector Parsing: The internal Selector and expressionToMap functions now support this configurable fallback, defaulting to the existing sourceIndex if no fallback key is specified.
• Store Initialization Refactor: The store.NewStore function now accepts a StoreConfig struct, encapsulating source and the new selector fallback key, leading to cleaner initialization.
• Command-Line Option: A new --selector-fallback-key flag has been added to the flagd command to allow users to specify this fallback behavior via command-line arguments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new configuration property, selector-fallback-key, which allows defining the key to be used when a selector string without an equals sign is provided. This enhances flexibility over the previous behavior, which always defaulted to 'source'. The changes are well-implemented, with updates to the store, configuration handling, and tests. I have a few suggestions to improve code clarity and maintainability.