-
Notifications
You must be signed in to change notification settings - Fork 358
add emmanuelbaa.md #3636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add emmanuelbaa.md #3636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start with 2 issues on your end
-
The link you've supplied doesn't lead to your profile preview(Replace the
mi
withvi
) -
The number of elements are currently below the threshold and don't feature one required element(hyperlink). I'd suggest adding a table, hyperlink and one additional element
open-learning-exchange.github.io/pages/vi/vi-github-and-markdown.md
Lines 110 to 116 in 57925cb
Before proceeding to the next section, please: - ensure that everything looks as expected and works correctly with the raw.githack link. - verify you used at least **5 different** Markdown elements in your profile - Must use clickable **hyperlinks** to reference for example your portfolio or other social profiles. - To use emojis in your profile, copy the actual emoji directly (e.g., '🐱' instead of ':emojicode:'). You can find and copy emojis from [emojipedia](https://emojipedia.org/). - Task lists are supported on GitHub but not on MDwiki. They may look correct on GitHub but not on MDwiki.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but your Github link does not seem to be working.
do i need to do re post it ? |
No, looks like you need to use the absolute url with |
Important: Do not tick a checkbox if you haven’t performed its action.
Before Creating the Pull Request
master
– it should say "compare: branch-name".add githubusername.md
.update mi-faq.md (fixes #3264)
.After Creating the Pull Request
Description, Screenshots and/or Screencast
fixes #3632
Raw.Githack Preview Link
https://raw.githack.com/emmanuelbaa/emmanuelbaa.github.io/add-emmanuelbaa-profile/index.html#!pages/vi/profiles/emmanuelbaa.md