Issue #32: Updated logging function declarations #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #32.
I've added the proper return types for functions in
logging/loggerbase.php
to fix the fatal errors occurring in PHPUnit tests.Environment Details
Branch that has the issue:
MOODLE_405_STABLE
How to recreate the issue?
MOODLE_405_STABLE
)vendor/bin/phpunit
-> the error only appears when running the full list of unit tests. Runningvendor/bin/phpunit --testsuite mod_collaborate_testsuite
yields no errors.Actual Output
Checkout to my branch, and you should see no PHP Fatal errors related to
mod_collaborate
when runningvendor/bin/phpunit
.