refactor: don't return error from opaTest #7560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the error is ignored and only printed to `testParams.errOutput` Signed-off-by: sspaink <sspaink@styra.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
johanfylling
approved these changes
May 19, 2025
| err := f.Close() | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
We do this often enough that it almost warrants a helper function.
aromeyer
pushed a commit
to aromeyer/opa
that referenced
this pull request
May 21, 2025
Signed-off-by: sspaink <sspaink@styra.com> Signed-off-by: aromeyer <alain.romeyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is ignored when executed by cobra and the errors are only printed to
testParams.errOutput. The returned error was being used in the tests but I updated those to use the error code instead.Also cleaned up all the formatting issues found in
test.goandtest_test.go.