[connector/spanmetrics] Use latest semantic conventions for status code attribute #43000
+160
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
github-actions
bot
requested review from
Frapschen,
iblancasa and
portertech
Machyne
force-pushed
the
mc/spanmetrics
branch
from
be23e17 to
ad9ec76
Compare
Frapschen
reviewed
Sep 26, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement |
There was a problem hiding this comment.
I believe it's a breaking change
Frapschen
reviewed
Sep 26, 2025
| component: spanmetricsconnector | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add a feature gate to use the latest semantic conventions for the status code attribute on generated metrics. |
There was a problem hiding this comment.
nit: We can use subtext to explain the rationale behind introducing this breaking change, as well as how to use feature gates to roll it back.
In note we explicitly say that the key of span status change from status.code to otel.status_code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a feature gate to use the latest semantic conventions for the status code attribute on generated metrics. Changes:
status.code=STATUS_CODE_ERRORotel.status_code=ERRORstatus.code=STATUS_CODE_OKotel.status_code=OKstatus.code=STATUS_CODE_UNSETLink to tracking issue
Partially Fixes #42103
Testing
Added new test case
"Test using new status code attribute"Documentation
[ ] TODO: looking for advice on documentation; do I need to add anything for the new feature gate?