-
Notifications
You must be signed in to change notification settings - Fork 692
Remove dup semconv support from HTTP packages #7584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d5ca5c
to
036c447
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7584 +/- ##
=======================================
- Coverage 81.5% 78.7% -2.9%
=======================================
Files 200 186 -14
Lines 18129 14807 -3322
=======================================
- Hits 14793 11656 -3137
+ Misses 2938 2803 -135
+ Partials 398 348 -50
🚀 New features to boost your workflow:
|
I know this is a quite large thing, and fixes some bits that were missed before (in echo and gin). |
Is there an extra "test" in this filename. |
No other issues, very nice. |
b8f5667
to
21b379f
Compare
There is both |
Yeah, you're right. We can focus on resolving just this current PR. |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
This is the first cleanup PR for the old semconv in HTTP libraries.
There will be (at least) another PR cleaning up the semconv package itself.