Skip to content

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 15, 2025

This is the first cleanup PR for the old semconv in HTTP libraries.
There will be (at least) another PR cleaning up the semconv package itself.

@dmathieu dmathieu force-pushed the remove-semconvutil branch from 3d5ca5c to 036c447 Compare July 15, 2025 11:58
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 86.46865% with 82 lines in your changes missing coverage. Please review.

Project coverage is 78.7%. Comparing base (b9a7621) to head (0fcaea7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...abstack/echo/otelecho/internal/semconv/httpconv.go 87.5% 35 Missing and 12 partials ⚠️
...com/labstack/echo/otelecho/internal/semconv/env.go 78.5% 23 Missing ⚠️
...om/labstack/echo/otelecho/internal/semconv/util.go 82.8% 10 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7584     +/-   ##
=======================================
- Coverage   81.5%   78.7%   -2.9%     
=======================================
  Files        200     186     -14     
  Lines      18129   14807   -3322     
=======================================
- Hits       14793   11656   -3137     
+ Misses      2938    2803    -135     
+ Partials     398     348     -50     
Files with missing lines Coverage Δ
...lei/go-restful/otelrestful/internal/semconv/env.go 78.5% <100.0%> (-13.2%) ⬇️
...umentation/github.com/gin-gonic/gin/otelgin/gin.go 93.2% <100.0%> (+0.1%) ⬆️
....com/gin-gonic/gin/otelgin/internal/semconv/env.go 78.5% <100.0%> (-13.2%) ⬇️
...ub.com/gorilla/mux/otelmux/internal/semconv/env.go 78.5% <100.0%> (-13.2%) ⬇️
...entation/github.com/labstack/echo/otelecho/echo.go 100.0% <100.0%> (ø)
...tp/httptrace/otelhttptrace/internal/semconv/env.go 78.5% <100.0%> (-13.2%) ⬇️
...entation/net/http/otelhttp/internal/semconv/env.go 78.5% <100.0%> (-13.2%) ⬇️
instrumentation/net/http/otelhttp/transport.go 95.0% <100.0%> (-0.1%) ⬇️
...om/labstack/echo/otelecho/internal/semconv/util.go 82.8% <82.8%> (ø)
...com/labstack/echo/otelecho/internal/semconv/env.go 78.5% <78.5%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review July 15, 2025 13:07
@dmathieu dmathieu requested a review from a team as a code owner July 15, 2025 13:07
@dmathieu
Copy link
Member Author

I know this is a quite large thing, and fixes some bits that were missed before (in echo and gin).

@flc1125
Copy link
Member

flc1125 commented Jul 15, 2025

instrumentation/github.com/labstack/echo/otelecho/echotest_test.go

Is there an extra "test" in this filename.

@flc1125
Copy link
Member

flc1125 commented Jul 15, 2025

No other issues, very nice.

@dmathieu dmathieu force-pushed the remove-semconvutil branch from b8f5667 to 21b379f Compare July 15, 2025 14:52
@dmathieu
Copy link
Member Author

instrumentation/github.com/labstack/echo/otelecho/echotest_test.go

Is there an extra "test" in this filename.

There is both echotest_test.go and echo_test.go. We may want to make things nicer, but not in this PR.

@flc1125
Copy link
Member

flc1125 commented Jul 15, 2025

There is both echotest_test.go and echo_test.go. We may want to make things nicer, but not in this PR.

Yeah, you're right. We can focus on resolving just this current PR.

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dmathieu dmathieu merged commit c1bbaea into open-telemetry:main Jul 16, 2025
28 of 29 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: HTTP Semconv Migration Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants