Skip to content

Test multiple Go verions in integration-test #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 11, 2025

Part of #2136

@MrAlias MrAlias force-pushed the matrix-compat-integration-test branch from 7342f11 to 4f1af47 Compare April 11, 2025 18:59
@MrAlias MrAlias force-pushed the matrix-compat-integration-test branch from 4f1af47 to 4c1bf43 Compare April 11, 2025 19:02
@MrAlias MrAlias marked this pull request as ready for review April 11, 2025 19:05
@MrAlias MrAlias requested a review from a team as a code owner April 11, 2025 19:05
@RonFed
Copy link
Contributor

RonFed commented Apr 11, 2025

Do you think we should add older versions? According to our compatibility doc we support go1.19 and above so maybe we should add go1.19 as well.

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 11, 2025

Do you think we should add older versions? According to our compatibility doc we support go1.19 and above so maybe we should add go1.19 as well.

That's going to be a bit harder. All of the project mod files require at least Go 1.23. We will not be able to compile the project with older versions.

To accomplish this type of testing we will need to update the integration tests to build the end-2-end test applications (i.e. nethttp, nethttp_custom) with different versions of Go.

Closing this as it is duplicating the verification that the project can be built with both versions of Go. A more comprehensive approach mentioned above is required instead.

@MrAlias MrAlias closed this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants