telemetry: add tests for trace id and span id encoding #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
May 5, 2025
There was a problem hiding this comment.
This is missing tests for the errors cases where the IDs are invalid lengths or they do not contain valid hex encoded data.
There was a problem hiding this comment.
@yumosx are you able to address the errors testing? Is this something you could add to this PR?
There was a problem hiding this comment.
@yumosx just checking were you able to address the errors? If so please feel free to update/rebase the branch
There was a problem hiding this comment.
Sorry, My oversight delayed this . I'll fix it promptly.
grcevski
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for trace id and span id encoding.