Skip to content

Conversation

breedx-splk
Copy link
Contributor

This moves the configuration for the linkdown checker from commandline args over to a toml config file. This is intended to improve consistency between the java repos, and aligns with contrib #1986 and others.

Might need a refresh after open-telemetry/opentelemetry-java-instrumentation#14155 goes in.

@breedx-splk breedx-splk requested a review from a team as a code owner June 30, 2025 21:01
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (1e763b2) to head (5800219).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7460   +/-   ##
=========================================
  Coverage     90.12%   90.12%           
  Complexity     7187     7187           
=========================================
  Files           814      814           
  Lines         21700    21700           
  Branches       2123     2123           
=========================================
  Hits          19557    19557           
  Misses         1477     1477           
  Partials        666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@breedx-splk
Copy link
Contributor Author

@breedx-splk breedx-splk marked this pull request as draft July 1, 2025 21:25
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

breedx-splk and others added 4 commits September 23, 2025 14:30
# Conflicts:
#	.github/workflows/reusable-markdown-link-check.yml
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@breedx-splk breedx-splk force-pushed the markdown_link_consistency branch from cff5820 to 8bffe45 Compare September 23, 2025 21:30
@breedx-splk breedx-splk marked this pull request as ready for review September 23, 2025 21:30
@zeitlinger
Copy link
Member

@jkwatson
Copy link
Contributor

@breedx-splk is this ready to go?

@breedx-splk
Copy link
Contributor Author

No, I think I should probably just close it and make a new one that realigns better with the template that changed before I could come back to it. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants