-
Notifications
You must be signed in to change notification settings - Fork 906
Add config file for the markdown checker #7460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add config file for the markdown checker #7460
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7460 +/- ##
=========================================
Coverage 90.12% 90.12%
Complexity 7187 7187
=========================================
Files 814 814
Lines 21700 21700
Branches 2123 2123
=========================================
Hits 19557 19557
Misses 1477 1477
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I want this to align with open-telemetry/opentelemetry-android#1037 and open-telemetry/opentelemetry-java-contrib#1986 and open-telemetry/opentelemetry-java-instrumentation#14155 so making draft... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
# Conflicts: # .github/workflows/reusable-markdown-link-check.yml
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
cff5820
to
8bffe45
Compare
This is the new template that @trask has created: https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/.github/workflows/reusable-link-check.yml |
@breedx-splk is this ready to go? |
No, I think I should probably just close it and make a new one that realigns better with the template that changed before I could come back to it. Sorry. |
This moves the configuration for the linkdown checker from commandline args over to a toml config file. This is intended to improve consistency between the java repos, and aligns with contrib #1986 and others.
Might need a refresh after open-telemetry/opentelemetry-java-instrumentation#14155 goes in.