Skip to content

Conversation

MilesChou
Copy link
Contributor

According to the definition in RFC 9110:

The 3xx (Redirection) class of status code indicates that further action needs to be taken by the user agent in order to fulfill the request.

The 3xx status code only signifies that additional steps are required to determine the result, but merely encountering a 3xx status code does not necessarily indicate an error. Therefore, it is recommended to make this adjustment.

@MilesChou MilesChou requested a review from a team September 4, 2024 02:08
Copy link

welcome bot commented Sep 4, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Sep 4, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@MilesChou
Copy link
Contributor Author

MilesChou commented Sep 4, 2024

EasyCLA Authorization is submitted.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (15427f3) to head (41f3982).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #291   +/-   ##
=========================================
  Coverage     84.80%   84.80%           
  Complexity      947      947           
=========================================
  Files            80       80           
  Lines          3798     3798           
=========================================
  Hits           3221     3221           
  Misses          577      577           
Flag Coverage Δ
Aws 85.75% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CodeIgniter 73.94% <ø> (ø)
Instrumentation/ExtAmqp 89.58% <ø> (ø)
Instrumentation/Guzzle 69.73% <ø> (ø)
Instrumentation/HttpAsyncClient 81.33% <ø> (ø)
Instrumentation/IO 70.90% <ø> (ø)
Instrumentation/MongoDB 77.33% <ø> (ø)
Instrumentation/OpenAIPHP 86.82% <ø> (ø)
Instrumentation/PDO 89.56% <ø> (ø)
Instrumentation/Psr14 78.12% <ø> (ø)
Instrumentation/Psr15 93.50% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 82.08% <ø> (ø)
Instrumentation/Psr3 61.03% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/Slim 86.95% <ø> (ø)
Instrumentation/Symfony 89.03% <ø> (ø)
Instrumentation/Yii 77.77% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Shims/OpenTracing 92.99% <ø> (ø)
Symfony 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15427f3...41f3982. Read the comment docs.

@brettmc brettmc merged commit 9b97522 into open-telemetry:main Sep 4, 2024
105 of 117 checks passed
@MilesChou MilesChou deleted the ignore-redirection-error branch September 5, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants