-
Notifications
You must be signed in to change notification settings - Fork 118
Record exception with stack trace on log records #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record exception with stack trace on log records #410
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Once the CLA has been signed we can merge this for you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
============================================
+ Coverage 81.46% 83.07% +1.61%
+ Complexity 1667 1530 -137
============================================
Files 120 97 -23
Lines 6953 6115 -838
============================================
- Hits 5664 5080 -584
+ Misses 1289 1035 -254 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Currently, exceptions on spans ARE presenting a useful stack trace whereas exceptions in logs ARE NOT presenting the stack trace.
As per otel semantic conventions:
https://opentelemetry.io/docs/specs/semconv/exceptions/exceptions-logs/
This proposal records the exception with stack trace on the log record, using a similar implementation to the
Span.php