Skip to content

Conversation

intuibase
Copy link
Contributor

Please take a look into README for instrumented functions set

@intuibase intuibase requested a review from a team as a code owner July 30, 2025 17:25
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 93.54839% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.90%. Comparing base (27b914a) to head (e6515b1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Instrumentation/PostgreSql/src/PgSqlTracker.php 84.07% 18 Missing ⚠️
...ation/PostgreSql/src/PostgreSqlInstrumentation.php 96.13% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #415      +/-   ##
============================================
+ Coverage     83.07%   83.90%   +0.83%     
- Complexity     1530     1662     +132     
============================================
  Files            97       99       +2     
  Lines          6115     6642     +527     
============================================
+ Hits           5080     5573     +493     
- Misses         1035     1069      +34     
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.42% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.55% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/Doctrine 92.92% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/PostgreSql 93.54% <93.54%> (?)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/PostgreSql/src/PostgreSqlInstrumentation.php 96.13% <96.13%> (ø)
...rc/Instrumentation/PostgreSql/src/PgSqlTracker.php 84.07% <84.07%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b914a...e6515b1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc
Copy link
Contributor

brettmc commented Jul 30, 2025

Looks good to me, it needs a gitsplit entry so we can publish

@ChrisLightfootWild
Copy link
Contributor

Looks good to me, it needs a gitsplit entry so we can publish

The .phan directory too, sorry I missed it earlier! 😅

@intuibase
Copy link
Contributor Author

Looks good to me, it needs a gitsplit entry so we can publish

The .phan directory too, sorry I missed it earlier! 😅

My fault, fixed.

@intuibase
Copy link
Contributor Author

Looks good to me, it needs a gitsplit entry so we can publish

I've just added it. It is ready to go.
You can remove comments from the intermediate commits during merge – they don’t add any value.

Should I add myself as a maintainer in the README.md? I saw that kind of info in some java isntrumentations.

@brettmc brettmc merged commit 4f5ff3e into open-telemetry:main Aug 1, 2025
144 of 156 checks passed
@brettmc
Copy link
Contributor

brettmc commented Aug 1, 2025

https://packagist.org/packages/open-telemetry/opentelemetry-auto-postgresql - I think packagist is complaining about "version" in composer.json: https://github.com/opentelemetry-php/contrib-auto-postgresql/blob/main/composer.json#L3
I think that line should be removed as a follow-up.

@intuibase intuibase deleted the postgresql_instrumentation branch August 3, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants