Skip to content

Conversation

weslenteche
Copy link
Contributor

@weslenteche weslenteche force-pushed the migrate-extension-propagator-cloudtrace branch from 61ff98a to da0bc1b Compare August 3, 2025 14:26
@weslenteche weslenteche marked this pull request as ready for review August 3, 2025 14:46
@weslenteche weslenteche requested a review from a team as a code owner August 3, 2025 14:46
@brettmc
Copy link
Contributor

brettmc commented Aug 4, 2025

LGTM, just that one issue with split destination. I think the order of things should be:

  1. merge and publish this
  2. abandon https://packagist.org/packages/open-telemetry/extension-propagator-cloudtrace (suggest contrib version as the replacement)
  3. merge the removal PR in opentelemetry-php

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 89.77273% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.88%. Comparing base (b6a81ac) to head (34b3809).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ropagation/CloudTrace/src/CloudTracePropagator.php 84.37% 5 Missing ⚠️
...Propagation/CloudTrace/src/CloudTraceFormatter.php 83.33% 3 Missing ⚠️
src/Propagation/CloudTrace/src/Utils.php 97.36% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #418      +/-   ##
============================================
+ Coverage     83.56%   83.88%   +0.31%     
- Complexity     1539     1697     +158     
============================================
  Files            96      102       +6     
  Lines          6285     6762     +477     
============================================
+ Hits           5252     5672     +420     
- Misses         1033     1090      +57     
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.42% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.98% <ø> (ø)
Instrumentation/Curl 87.66% <ø> (?)
Instrumentation/Doctrine 92.92% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/PostgreSql 93.54% <ø> (ø)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <ø> (ø)
Instrumentation/Yii 77.86% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/CloudTrace 89.77% <89.77%> (?)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Propagation/CloudTrace/src/Utils.php 97.36% <97.36%> (ø)
...Propagation/CloudTrace/src/CloudTraceFormatter.php 83.33% <83.33%> (ø)
...ropagation/CloudTrace/src/CloudTracePropagator.php 84.37% <84.37%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a81ac...34b3809. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc merged commit ffff74e into open-telemetry:main Aug 8, 2025
148 of 160 checks passed
@brettmc
Copy link
Contributor

brettmc commented Aug 8, 2025

merged and published to packagist. a minor follow-up fix is that the readme still says: composer require open-telemetry/extension-propagator-cloudtrace, @weslenteche

@weslenteche weslenteche deleted the migrate-extension-propagator-cloudtrace branch August 8, 2025 01:18
@weslenteche
Copy link
Contributor Author

weslenteche commented Aug 8, 2025

Good point, I created the PR (#427) to update the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants