-
Notifications
You must be signed in to change notification settings - Fork 117
migrate extension propagator cloudtrace #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate extension propagator cloudtrace #418
Conversation
61ff98a
to
da0bc1b
Compare
LGTM, just that one issue with split destination. I think the order of things should be:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
============================================
+ Coverage 83.56% 83.88% +0.31%
- Complexity 1539 1697 +158
============================================
Files 96 102 +6
Lines 6285 6762 +477
============================================
+ Hits 5252 5672 +420
- Misses 1033 1090 +57 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
merged and published to packagist. a minor follow-up fix is that the readme still says: |
Good point, I created the PR (#427) to update the readme |
Resolving open-telemetry/opentelemetry-php#1609